[odbccpp] Add new port by florsap · Pull Request #50152 · microsoft/vcpkg

florsap · 2026-02-24T08:27:20Z

Changes comply with the maintainer guide.
The packaged project shows strong association with the chosen port name. Check this box if at least one of the following criteria is met:
- The project is amongst the first web search results for "" or " C++". Include a screenshot of the search engine results in the PR.

Optional dependencies of the build are all controlled by the port. A dependency is controlled if it is declared an unconditional dependency in vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGE
The versioning scheme in vcpkg.json matches what upstream says.
The license declaration in vcpkg.json matches what upstream says.
The source code of the component installed comes from an authoritative source.
The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.

florsap · 2026-02-24T08:30:57Z

@microsoft-github-policy-service agree [company="SAP"]

florsap · 2026-02-24T08:31:39Z

@microsoft-github-policy-service agree company="SAP"

This reverts commit 937cdc4.

dg0yt · 2026-02-26T07:07:56Z

+  "dependencies": [
+    {
+      "name": "unixodbc",
+      "platform": "linux | osx"


How is ODBC provided on other platforms which are not !windows?

Thanks for taking a look. In general I oriented on nanodbc and freetds, but I took the platform here from the supports config of unixodbc (https://github.com/microsoft/vcpkg/blob/b2f068faf45a3f04145bec0f52a66526ad590227/ports/unixodbc/vcpkg.json). For other platforms it must be provided by the system. Let me know if I miss something, I have no issue to change it to !windows if it makes sense.

Following unixodbc's supports is right.

dg0yt · 2026-02-26T07:09:29Z

+-FIND_PACKAGE(ODBC REQUIRED)
+IF(UNIX)
+    FIND_PACKAGE(unixodbc CONFIG)
+    IF(unixodbc_FOUND)
+        SET(ODBC_TARGET UNIX::odbc)
+    ENDIF()
+ENDIF()
+IF(NOT ODBC_TARGET)
+    FIND_PACKAGE(ODBC REQUIRED)
+    SET(ODBC_TARGET ODBC::ODBC)
+ENDIF()


This must match the dependencies expressed in the manifests. I have more suggestions once the manifest dependency question is answered.

Good point, this is wrongfully adapted. Depending on the result of the other comment, this probably should be IF(LINUX OR APPLE).

This must match the dependencies expressed in the manifests. I have more suggestions once the manifest dependency question is answered.

~~@dg0yt, is there anything else you want to suggest? Otherwise, this port looks good to go to me~~

IF(UNIX) still seems wrong to me. This would become an installation order dependency when unixodbc is extended to support bsd or ios or android.

The safest wiring would be an option which is controlled by the portfile. Here (project mode):

if(ODBCCPP_USE_UNIXODBC) FIND_PACKAGE(unofficial-unixodbc CONFIG REQUIRED) SET(ODBC_TARGET unofficial::unixodbc::unixodbc) ELSE() ...

and in the portfile (vcpkg script mode):

vcpkg_list(SET options) if(VCPKG_TARGET_IS_LINUX OR VCPKG_TARGET_IS_OSX) list(APPEND options -DODBCCPP_USE_UNIXODBC=ON) endif() vcpkg_cmake_configure( ... OPTIONS ${options} ... )

I would probably create an alias ODBC::ODBC instead of replacing its use with a variable.

There is no installed CMake config. But unless using dynamic loading, there are conditional transitive usage requirements. User must duplicate the condition.

Thanks for the careful check. I added a config file to odbccpp, this is a good thing anyway. Also, I added your suggestions, I hope it fits now.

This reverts commit af41392.

florsap · 2026-02-27T16:16:03Z

Hey, Odbccpp is an open source wrapper for the odbc api to use in c++. Currently, it is mostly used for two other open source projects GDAL and QGIS, it would be cool for them to have it available in vcpkg.
I hope the change is fine, I tried to orient on available ports and hopefully didn't miss anything in the maintainer guide. Thanks for taking a look and maybe considering it.

JavierMatosD

Tagging team review to discuss the proper find_package call

JavierMatosD · 2026-03-02T22:15:32Z

+
+-FIND_PACKAGE(ODBC REQUIRED)
+IF(UNIX)
+    FIND_PACKAGE(unixodbc CONFIG)


Hmm.. https://github.com/microsoft/vcpkg/blob/master/ports/unixodbc/usage#L4 I'll need to consult the team since this ports exports unofficial targets. Tagging vcpkg-team-review

Ok, it seems this is allowed and this should use the vcpkg provided configs instead.

Hey Javier, thanks for checking the change. I used the directions in the usage file of unixodbc: https://github.com/microsoft/vcpkg/blob/39a6cc0e44641977a7ccdfdb01a14eaf832aa330/ports/unixodbc/usage

Still, this failed. I think the correct target is unofficial::unixodbc::unixodbc, at least for me it looks like when checking the config https://github.com/microsoft/vcpkg/blob/39a6cc0e44641977a7ccdfdb01a14eaf832aa330/ports/unixodbc/unofficial-unixodbc-config.cmake

If this is correct and it makes sense, I could open an issue or push a small fix.

JavierMatosD · 2026-03-02T22:19:20Z

+  "dependencies": [
+    {
+      "name": "unixodbc",
+      "platform": "!windows"


The port in vcpkg supports "linux | osx"

Fixed it. I thought the same originally, but it seems to be the common way to use !windows for other packages. https://github.com/search?q=repo%3Amicrosoft%2Fvcpkg+%22name%22%3A+%22unixodbc%22%2C+++++++%22platform%22%3A+%22%21windows%22&type=code

But I'm fine with either and for me "linux | osx" seems to be more precise, too.

This reverts commit 03d31da.

JavierMatosD · 2026-03-05T21:43:24Z

+-FIND_PACKAGE(ODBC REQUIRED)
+IF(UNIX)
+    FIND_PACKAGE(unofficial-unixodbc CONFIG)
+    IF(unixodbc_FOUND)


Suggested change

+ IF(unixodbc_FOUND)

+ IF(unofficial-unixodbc_FOUND)

I haven't dug too deep into the problem here but I suspect that this is still falling back to the find_package(ODBC REQUIRED) call below which ends up searching for odbc_config and attempts to execute it.

JavierMatosD · 2026-03-05T21:43:54Z

+IF(NOT ODBC_TARGET)
+    FIND_PACKAGE(ODBC REQUIRED)
+    SET(ODBC_TARGET ODBC::ODBC)
+ENDIF()


Suggested change

+IF(NOT ODBC_TARGET)

+ FIND_PACKAGE(ODBC REQUIRED)

+ SET(ODBC_TARGET ODBC::ODBC)

+ENDIF()

I don't think this fallback is needed.

I changed it to an if else clause, but in general it is necessary for for Windows, I think. Hope this fits for you.

dg0yt

Hm, my review wasn't submitted when I wrote it.

dg0yt · 2026-03-05T04:57:40Z

+  "dependencies": [
+    {
+      "name": "unixodbc",
+      "platform": "linux | osx"


Following unixodbc's supports is right.

dg0yt · 2026-03-05T04:59:46Z

+-FIND_PACKAGE(ODBC REQUIRED)
+IF(UNIX)
+    FIND_PACKAGE(unixodbc CONFIG)
+    IF(unixodbc_FOUND)
+        SET(ODBC_TARGET UNIX::odbc)
+    ENDIF()
+ENDIF()
+IF(NOT ODBC_TARGET)
+    FIND_PACKAGE(ODBC REQUIRED)
+    SET(ODBC_TARGET ODBC::ODBC)
+ENDIF()


IF(UNIX) still seems wrong to me. This would become an installation order dependency when unixodbc is extended to support bsd or ios or android.

dg0yt · 2026-03-05T05:06:58Z

+-FIND_PACKAGE(ODBC REQUIRED)
+IF(UNIX)
+    FIND_PACKAGE(unixodbc CONFIG)
+    IF(unixodbc_FOUND)
+        SET(ODBC_TARGET UNIX::odbc)
+    ENDIF()
+ENDIF()
+IF(NOT ODBC_TARGET)
+    FIND_PACKAGE(ODBC REQUIRED)
+    SET(ODBC_TARGET ODBC::ODBC)
+ENDIF()


The safest wiring would be an option which is controlled by the portfile. Here (project mode):

if(ODBCCPP_USE_UNIXODBC) FIND_PACKAGE(unofficial-unixodbc CONFIG REQUIRED) SET(ODBC_TARGET unofficial::unixodbc::unixodbc) ELSE() ...

and in the portfile (vcpkg script mode):

vcpkg_list(SET options) if(VCPKG_TARGET_IS_LINUX OR VCPKG_TARGET_IS_OSX) list(APPEND options -DODBCCPP_USE_UNIXODBC=ON) endif() vcpkg_cmake_configure( ... OPTIONS ${options} ... )

I would probably create an alias ODBC::ODBC instead of replacing its use with a variable.

There is no installed CMake config. But unless using dynamic loading, there are conditional transitive usage requirements. User must duplicate the condition.

This reverts commit 8078683.

This reverts commit 3d4c8e9.

Javier has left Microsoft.

azure-pipelines · 2026-04-15T23:55:29Z

Azure Pipelines: Successfully started running 1 pipeline(s).

BillyONeal · 2026-04-16T00:06:53Z

+
+vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/${PORT})
+
+vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE")


We should add the missing terminating newline if we need to edit this again for some reason.

BillyONeal

This looks fine to me but I don't know if I would have noticed what @dg0yt said before. Will check back tomorrow if/when builds succeed and see if anyone else has thoughts before merging. (But I never looked at the before so 🤷 )

BillyONeal · 2026-04-16T21:18:50Z

Thanks for the new port!

florsap added 3 commits February 20, 2026 21:40

Add odbccpp to vcpkg

a7ea7ea

version database

937cdc4

Merge branch 'microsoft:master' into add-odbccpp

c95f982

JavierMatosD marked this pull request as draft February 24, 2026 15:20

florsap added 3 commits February 25, 2026 15:11

Revert "version database"

8810753

This reverts commit 937cdc4.

Fix locations of dlls in windows

b763f24

version database

af41392

dg0yt reviewed Feb 26, 2026

View reviewed changes

florsap added 3 commits February 27, 2026 13:20

Revert "version database"

44e8c9e

This reverts commit af41392.

Remove unecessary dynamic build and exclude android

2ac765b

version database

03d31da

florsap marked this pull request as ready for review February 27, 2026 16:16

florsap marked this pull request as draft February 27, 2026 18:36

florsap marked this pull request as ready for review March 2, 2026 08:14

JavierMatosD suggested changes Mar 2, 2026

View reviewed changes

JavierMatosD added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. and removed requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Mar 2, 2026

JavierMatosD marked this pull request as draft March 2, 2026 22:40

florsap added 3 commits March 3, 2026 11:34

Revert "version database"

f5087a4

This reverts commit 03d31da.

Fix review comments

8615dfb

version database

8078683

florsap marked this pull request as ready for review March 3, 2026 11:29

JavierMatosD approved these changes Mar 3, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/master' into HEAD

d6459cc

JavierMatosD previously requested changes Mar 5, 2026

View reviewed changes

JavierMatosD marked this pull request as draft March 5, 2026 21:44

dg0yt reviewed Mar 5, 2026

View reviewed changes

florsap added 7 commits March 30, 2026 16:55

Merge branch 'microsoft:master' into add-odbccpp

fc3442f

Revert "version database"

906eaf6

This reverts commit 8078683.

Fix review comments

53ab57e

version database

3d4c8e9

Revert "version database"

b01fd81

This reverts commit 3d4c8e9.

Fix review comments

cb172d5

version database

cf9cbe1

florsap marked this pull request as ready for review April 13, 2026 06:27

florsap requested a review from JavierMatosD April 14, 2026 10:36

Merge branch 'master' into add-odbccpp

8126a06

BillyONeal reviewed Apr 16, 2026

View reviewed changes

BillyONeal approved these changes Apr 16, 2026

View reviewed changes

BillyONeal merged commit 36ca7d1 into microsoft:master Apr 16, 2026
16 checks passed


		vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/${PORT})

		vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE") No newline at end of file

Conversation

florsap commented Feb 24, 2026

Uh oh!

florsap commented Feb 24, 2026

Uh oh!

florsap commented Feb 24, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JavierMatosD Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

florsap commented Feb 27, 2026

Uh oh!

JavierMatosD left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dg0yt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Apr 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BillyONeal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillyONeal commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JavierMatosD Mar 3, 2026 •

edited

Loading