Skip to content

Add capability and non-hero references for Python skills#382

Merged
LarryOsterman merged 26 commits into
mainfrom
larryo/split/python-skill-references
Jul 15, 2026
Merged

Add capability and non-hero references for Python skills#382
LarryOsterman merged 26 commits into
mainfrom
larryo/split/python-skill-references

Conversation

@LarryOsterman

Copy link
Copy Markdown
Member

Split from #375 (4 of 5).

Expands Python skill documentation:

  • Adds references/capabilities.md and references/non-hero-scenarios.md to ~30 azure-sdk-python skills
  • Updates the corresponding SKILL.md files
  • Refreshes .github/skills/*-py symlink pointers

135 files, all under .github/plugins/azure-sdk-python/ and .github/skills/.

Split from #375: adds references/capabilities.md and
references/non-hero-scenarios.md across ~30 azure-sdk-python skills,
updates their SKILL.md files, and refreshes .github/skills symlinks.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9429ad33-6f31-4ec5-ba00-0f11b5afb82e
@LarryOsterman

Copy link
Copy Markdown
Member Author

Split from #375 (see #375 for the full split plan). Do not merge #375 until this and the sibling split PRs (#379, #380, #381, #382, #383) are merged.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Expands Azure SDK Python skills with capability indexes, non-hero scenarios, lifecycle guidance, and refreshed compatibility symlinks.

Changes:

  • Adds capability and advanced-scenario references across 31 skills.
  • Updates skill guidance and selected SDK examples.
  • Refreshes 40 .github/skills/*-py symlinks.

Reviewed changes

Copilot reviewed 135 out of 135 changed files in this pull request and generated 32 comments.

Show a summary per file
File Description
.github/plugins/azure-sdk-python/skills/pydantic-models-py/SKILL.md Links capability reference.
.github/plugins/azure-sdk-python/skills/pydantic-models-py/references/capabilities.md Adds capability index.
.github/plugins/azure-sdk-python/skills/m365-agents-py/SKILL.md Adds lifecycle guidance and reference.
.github/plugins/azure-sdk-python/skills/m365-agents-py/references/capabilities.md Adds M365 capability reference.
.github/plugins/azure-sdk-python/skills/fastapi-router-py/SKILL.md Updates async guidance and reference.
.github/plugins/azure-sdk-python/skills/fastapi-router-py/references/capabilities.md Adds FastAPI capability index.
.github/plugins/azure-sdk-python/skills/azure-storage-queue-py/SKILL.md Links queue references.
.github/plugins/azure-sdk-python/skills/azure-storage-queue-py/references/non-hero-scenarios.md Adds advanced queue examples.
.github/plugins/azure-sdk-python/skills/azure-storage-queue-py/references/capabilities.md Indexes queue capabilities.
.github/plugins/azure-sdk-python/skills/azure-storage-file-share-py/SKILL.md Links file-share references.
.github/plugins/azure-sdk-python/skills/azure-storage-file-share-py/references/non-hero-scenarios.md Adds snapshot and async examples.
.github/plugins/azure-sdk-python/skills/azure-storage-file-share-py/references/capabilities.md Indexes file-share capabilities.
.github/plugins/azure-sdk-python/skills/azure-storage-file-datalake-py/SKILL.md Links Data Lake references.
.github/plugins/azure-sdk-python/skills/azure-storage-file-datalake-py/references/non-hero-scenarios.md Adds listing, ACL, and async examples.
.github/plugins/azure-sdk-python/skills/azure-storage-file-datalake-py/references/capabilities.md Indexes Data Lake capabilities.
.github/plugins/azure-sdk-python/skills/azure-storage-blob-py/SKILL.md Links Blob references.
.github/plugins/azure-sdk-python/skills/azure-storage-blob-py/references/non-hero-scenarios.md Adds metadata and async examples.
.github/plugins/azure-sdk-python/skills/azure-storage-blob-py/references/capabilities.md Indexes Blob capabilities.
.github/plugins/azure-sdk-python/skills/azure-speech-to-text-rest-py/SKILL.md Expands REST authentication guidance.
.github/plugins/azure-sdk-python/skills/azure-monitor-query-py/SKILL.md Links Monitor Query references.
.github/plugins/azure-sdk-python/skills/azure-monitor-query-py/references/non-hero-scenarios.md Adds client overview.
.github/plugins/azure-sdk-python/skills/azure-monitor-query-py/references/capabilities.md Indexes query capabilities.
.github/plugins/azure-sdk-python/skills/azure-monitor-opentelemetry-py/SKILL.md Expands telemetry lifecycle guidance.
.github/plugins/azure-sdk-python/skills/azure-monitor-opentelemetry-py/references/non-hero-scenarios.md Adds telemetry configuration examples.
.github/plugins/azure-sdk-python/skills/azure-monitor-opentelemetry-py/references/capabilities.md Indexes distro capabilities.
.github/plugins/azure-sdk-python/skills/azure-monitor-opentelemetry-exporter-py/SKILL.md Expands exporter lifecycle guidance.
.github/plugins/azure-sdk-python/skills/azure-monitor-opentelemetry-exporter-py/references/non-hero-scenarios.md Adds exporter scenarios.
.github/plugins/azure-sdk-python/skills/azure-monitor-opentelemetry-exporter-py/references/capabilities.md Indexes exporter capabilities.
.github/plugins/azure-sdk-python/skills/azure-monitor-ingestion-py/SKILL.md Links ingestion references.
.github/plugins/azure-sdk-python/skills/azure-monitor-ingestion-py/references/non-hero-scenarios.md Adds ingestion scenarios.
.github/plugins/azure-sdk-python/skills/azure-monitor-ingestion-py/references/capabilities.md Indexes ingestion capabilities.
.github/plugins/azure-sdk-python/skills/azure-mgmt-fabric-py/SKILL.md Links Fabric references.
.github/plugins/azure-sdk-python/skills/azure-mgmt-fabric-py/references/non-hero-scenarios.md Adds capacity-management examples.
.github/plugins/azure-sdk-python/skills/azure-mgmt-fabric-py/references/capabilities.md Indexes Fabric capabilities.
.github/plugins/azure-sdk-python/skills/azure-mgmt-botservice-py/SKILL.md Links Bot Service references.
.github/plugins/azure-sdk-python/skills/azure-mgmt-botservice-py/references/non-hero-scenarios.md Adds channel and OAuth examples.
.github/plugins/azure-sdk-python/skills/azure-mgmt-botservice-py/references/capabilities.md Indexes Bot Service capabilities.
.github/plugins/azure-sdk-python/skills/azure-mgmt-apimanagement-py/SKILL.md Links APIM references.
.github/plugins/azure-sdk-python/skills/azure-mgmt-apimanagement-py/references/non-hero-scenarios.md Adds APIM resource examples.
.github/plugins/azure-sdk-python/skills/azure-mgmt-apimanagement-py/references/capabilities.md Indexes APIM capabilities.
.github/plugins/azure-sdk-python/skills/azure-mgmt-apicenter-py/SKILL.md Updates API Center model usage.
.github/plugins/azure-sdk-python/skills/azure-mgmt-apicenter-py/references/non-hero-scenarios.md Adds API Center scenarios.
.github/plugins/azure-sdk-python/skills/azure-mgmt-apicenter-py/references/capabilities.md Indexes API Center capabilities.
.github/plugins/azure-sdk-python/skills/azure-messaging-webpubsubservice-py/SKILL.md Links Web PubSub references.
.github/plugins/azure-sdk-python/skills/azure-messaging-webpubsubservice-py/references/non-hero-scenarios.md Adds operational-hardening reference.
.github/plugins/azure-sdk-python/skills/azure-messaging-webpubsubservice-py/references/capabilities.md Indexes Web PubSub capabilities.
.github/plugins/azure-sdk-python/skills/azure-keyvault-py/SKILL.md Links Key Vault references.
.github/plugins/azure-sdk-python/skills/azure-keyvault-py/references/non-hero-scenarios.md Adds async and error examples.
.github/plugins/azure-sdk-python/skills/azure-keyvault-py/references/capabilities.md Indexes Key Vault capabilities.
.github/plugins/azure-sdk-python/skills/azure-identity-py/SKILL.md Expands credential lifecycle guidance.
.github/plugins/azure-sdk-python/skills/azure-identity-py/references/non-hero-scenarios.md Adds advanced identity scenarios.
.github/plugins/azure-sdk-python/skills/azure-identity-py/references/capabilities.md Indexes Identity capabilities.
.github/plugins/azure-sdk-python/skills/azure-eventgrid-py/SKILL.md Links Event Grid references.
.github/plugins/azure-sdk-python/skills/azure-eventgrid-py/references/non-hero-scenarios.md Adds async and namespace examples.
.github/plugins/azure-sdk-python/skills/azure-eventgrid-py/references/capabilities.md Indexes Event Grid capabilities.
.github/plugins/azure-sdk-python/skills/azure-data-tables-py/SKILL.md Links Tables references.
.github/plugins/azure-sdk-python/skills/azure-data-tables-py/references/non-hero-scenarios.md Adds batch and async examples.
.github/plugins/azure-sdk-python/skills/azure-data-tables-py/references/capabilities.md Indexes Tables capabilities.
.github/plugins/azure-sdk-python/skills/azure-cosmos-py/scripts/setup_cosmos_container.py Fixes syntax and formatting.
.github/plugins/azure-sdk-python/skills/azure-cosmos-db-py/SKILL.md Generalizes sync/async guidance.
.github/plugins/azure-sdk-python/skills/azure-containerregistry-py/SKILL.md Links Container Registry references.
.github/plugins/azure-sdk-python/skills/azure-containerregistry-py/references/non-hero-scenarios.md Adds artifact and cleanup examples.
.github/plugins/azure-sdk-python/skills/azure-containerregistry-py/references/capabilities.md Indexes registry capabilities.
.github/plugins/azure-sdk-python/skills/azure-appconfiguration-py/SKILL.md Links App Configuration references.
.github/plugins/azure-sdk-python/skills/azure-appconfiguration-py/references/non-hero-scenarios.md Adds snapshot and async examples.
.github/plugins/azure-sdk-python/skills/azure-appconfiguration-py/references/capabilities.md Indexes configuration capabilities.
.github/plugins/azure-sdk-python/skills/azure-ai-voicelive-py/SKILL.md Clarifies async-only guidance.
.github/plugins/azure-sdk-python/skills/azure-ai-vision-imageanalysis-py/SKILL.md Links Image Analysis references.
.github/plugins/azure-sdk-python/skills/azure-ai-vision-imageanalysis-py/references/non-hero-scenarios.md Adds visual-analysis examples.
.github/plugins/azure-sdk-python/skills/azure-ai-vision-imageanalysis-py/references/capabilities.md Indexes vision capabilities.
.github/plugins/azure-sdk-python/skills/azure-ai-translation-text-py/SKILL.md Links text-translation references.
.github/plugins/azure-sdk-python/skills/azure-ai-translation-text-py/references/non-hero-scenarios.md Adds translation scenarios.
.github/plugins/azure-sdk-python/skills/azure-ai-translation-text-py/references/capabilities.md Indexes text-translation capabilities.
.github/plugins/azure-sdk-python/skills/azure-ai-translation-document-py/SKILL.md Links document-translation references.
.github/plugins/azure-sdk-python/skills/azure-ai-translation-document-py/references/non-hero-scenarios.md Adds document-translation scenarios.
.github/plugins/azure-sdk-python/skills/azure-ai-translation-document-py/references/capabilities.md Indexes document capabilities.
.github/plugins/azure-sdk-python/skills/azure-ai-transcription-py/SKILL.md Expands authentication guidance.
.github/plugins/azure-sdk-python/skills/azure-ai-transcription-py/references/non-hero-scenarios.md Adds operational-hardening reference.
.github/plugins/azure-sdk-python/skills/azure-ai-transcription-py/references/capabilities.md Indexes transcription capabilities.
.github/plugins/azure-sdk-python/skills/azure-ai-textanalytics-py/SKILL.md Links Text Analytics references.
.github/plugins/azure-sdk-python/skills/azure-ai-textanalytics-py/references/non-hero-scenarios.md Adds advanced NLP examples.
.github/plugins/azure-sdk-python/skills/azure-ai-textanalytics-py/references/capabilities.md Indexes NLP capabilities.
.github/plugins/azure-sdk-python/skills/azure-ai-ml-py/SKILL.md Links Azure ML references.
.github/plugins/azure-sdk-python/skills/azure-ai-ml-py/references/non-hero-scenarios.md Adds job and pipeline examples.
.github/plugins/azure-sdk-python/skills/azure-ai-ml-py/references/capabilities.md Indexes Azure ML capabilities.
.github/plugins/azure-sdk-python/skills/azure-ai-language-conversations-py/SKILL.md Links conversation references.
.github/plugins/azure-sdk-python/skills/azure-ai-language-conversations-py/references/non-hero-scenarios.md Adds operational-hardening reference.
.github/plugins/azure-sdk-python/skills/azure-ai-language-conversations-py/references/capabilities.md Indexes conversation capabilities.
.github/plugins/azure-sdk-python/skills/azure-ai-contentunderstanding-py/SKILL.md Links Content Understanding references.
.github/plugins/azure-sdk-python/skills/azure-ai-contentunderstanding-py/references/non-hero-scenarios.md Adds multimodal and analyzer examples.
.github/plugins/azure-sdk-python/skills/azure-ai-contentunderstanding-py/references/capabilities.md Indexes Content Understanding capabilities.
.github/plugins/azure-sdk-python/skills/azure-ai-contentsafety-py/SKILL.md Links Content Safety references.
.github/plugins/azure-sdk-python/skills/azure-ai-contentsafety-py/references/non-hero-scenarios.md Adds category and severity tables.
.github/plugins/azure-sdk-python/skills/azure-ai-contentsafety-py/references/capabilities.md Indexes Content Safety capabilities.
.github/plugins/azure-sdk-python/skills/agent-framework-azure-ai-py/SKILL.md Clarifies async-first guidance.
.github/skills/agent-framework-azure-ai-py Refreshes plugin symlink.
.github/skills/azure-ai-contentsafety-py Refreshes plugin symlink.
.github/skills/azure-ai-contentunderstanding-py Refreshes plugin symlink.
.github/skills/azure-ai-language-conversations-py Refreshes plugin symlink.
.github/skills/azure-ai-ml-py Refreshes plugin symlink.
.github/skills/azure-ai-projects-py Refreshes plugin symlink.
.github/skills/azure-ai-textanalytics-py Refreshes plugin symlink.
.github/skills/azure-ai-transcription-py Refreshes plugin symlink.
.github/skills/azure-ai-translation-document-py Refreshes plugin symlink.
.github/skills/azure-ai-translation-text-py Refreshes plugin symlink.
.github/skills/azure-ai-vision-imageanalysis-py Refreshes plugin symlink.
.github/skills/azure-ai-voicelive-py Refreshes plugin symlink.
.github/skills/azure-appconfiguration-py Refreshes plugin symlink.
.github/skills/azure-containerregistry-py Refreshes plugin symlink.
.github/skills/azure-cosmos-db-py Refreshes plugin symlink.
.github/skills/azure-cosmos-py Refreshes plugin symlink.
.github/skills/azure-data-tables-py Refreshes plugin symlink.
.github/skills/azure-eventgrid-py Refreshes plugin symlink.
.github/skills/azure-eventhub-py Refreshes plugin symlink.
.github/skills/azure-identity-py Refreshes plugin symlink.
.github/skills/azure-keyvault-py Refreshes plugin symlink.
.github/skills/azure-messaging-webpubsubservice-py Refreshes plugin symlink.
.github/skills/azure-mgmt-apicenter-py Refreshes plugin symlink.
.github/skills/azure-mgmt-apimanagement-py Refreshes plugin symlink.
.github/skills/azure-mgmt-botservice-py Refreshes plugin symlink.
.github/skills/azure-mgmt-fabric-py Refreshes plugin symlink.
.github/skills/azure-monitor-ingestion-py Refreshes plugin symlink.
.github/skills/azure-monitor-opentelemetry-exporter-py Refreshes plugin symlink.
.github/skills/azure-monitor-opentelemetry-py Refreshes plugin symlink.
.github/skills/azure-monitor-query-py Refreshes plugin symlink.
.github/skills/azure-search-documents-py Refreshes plugin symlink.
.github/skills/azure-servicebus-py Refreshes plugin symlink.
.github/skills/azure-speech-to-text-rest-py Refreshes plugin symlink.
.github/skills/azure-storage-blob-py Refreshes plugin symlink.
.github/skills/azure-storage-file-datalake-py Refreshes plugin symlink.
.github/skills/azure-storage-file-share-py Refreshes plugin symlink.
.github/skills/azure-storage-queue-py Refreshes plugin symlink.
.github/skills/fastapi-router-py Refreshes plugin symlink.
.github/skills/m365-agents-py Refreshes plugin symlink.
.github/skills/pydantic-models-py Refreshes plugin symlink.

Comment thread .github/plugins/azure-sdk-python/skills/fastapi-router-py/SKILL.md Outdated
Copilot AI review requested due to automatic review settings July 15, 2026 18:02
@LarryOsterman
LarryOsterman removed the request for review from Copilot July 15, 2026 18:02
Copilot AI review requested due to automatic review settings July 15, 2026 18:05
@LarryOsterman
LarryOsterman removed the request for review from Copilot July 15, 2026 18:05
Copilot AI review requested due to automatic review settings July 15, 2026 18:05
@LarryOsterman
LarryOsterman removed the request for review from Copilot July 15, 2026 18:05
Copilot AI review requested due to automatic review settings July 15, 2026 18:07
@LarryOsterman
LarryOsterman removed the request for review from Copilot July 15, 2026 18:07
Copilot AI added 2 commits July 15, 2026 19:43
- Fix pnpm-workspace.yaml: resolve esbuild allowBuilds placeholder
- Fix azure-mgmt-apicenter non-hero: add missing closing parenthesis
- Fix azure-monitor-opentelemetry SKILL.md: flush() → force_flush()
- Fix azure-monitor-opentelemetry-exporter SKILL.md: flush() → force_flush()
- Fix azure-storage-queue non-hero: re-raise instead of silently passing exception
- Fix azure-identity non-hero: log and re-raise auth errors instead of silently passing
- Fix azure-ai-contentunderstanding non-hero: AnalysisInput → AnalyzeInput, fix model imports
- Fix azure-ai-transcription SKILL.md + non-hero: use AzureKeyCredential wrapper
- Fix m365-agents capabilities.md: complete CopilotClient example end-to-end
Copilot stopped reviewing on behalf of LarryOsterman due to an error July 15, 2026 19:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 136 out of 136 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (7)

.github/plugins/azure-sdk-python/skills/pydantic-models-py/references/capabilities.md:1

  • Direct BaseModel(...) construction also runs Pydantic validators and coercion, so this guidance is inaccurate. Recommend model_validate specifically when validating an existing mapping or object, and distinguish it from model_construct, which bypasses validation.
    .github/plugins/azure-sdk-python/skills/m365-agents-py/references/capabilities.md:1
  • acquire_token_silent can return None or an error response even when an account exists, causing this return to fail instead of trying interactive authentication. Check for access_token, fall back to acquire_token_interactive when silent acquisition fails, and raise an explicit authentication error if the final response still has no token.
    .github/plugins/azure-sdk-python/skills/m365-agents-py/references/capabilities.md:1
  • The sample requires explicit cleanup but never performs it. Pass a context-managed HTTP session through the client's supported session parameter, or close the client's underlying resources in a finally block, so the example does not leak network resources.
    .github/plugins/azure-sdk-python/skills/azure-mgmt-botservice-py/references/non-hero-scenarios.md:1
  • BotsOperations.update expects its request resource through the parameters argument, not a properties keyword containing BotProperties. Wrap these properties in the appropriate Bot resource and pass that resource as parameters; otherwise the example raises an unexpected-keyword error.
    .github/plugins/azure-sdk-python/skills/azure-mgmt-apicenter-py/SKILL.md:1
  • MetadataSchemaProperties also requires the metadata assignment targets. Add assigned_to with the applicable MetadataAssignmentEntity values; without it, this constructor is incomplete. Apply the same correction to the duplicated example in references/non-hero-scenarios.md.
    .github/plugins/azure-sdk-python/skills/azure-messaging-webpubsubservice-py/references/non-hero-scenarios.md:1
  • close_all_connections does not target a user and does not accept user_id; the user-specific operation is close_user_connections. Use that method here so the example closes only this user's connections as described.
    .github/plugins/azure-sdk-python/skills/azure-messaging-webpubsubservice-py/references/non-hero-scenarios.md:1
  • The connection URL contains the bearer access token, so printing it exposes a usable credential through console or application logs. Pass the URL directly to the intended client and redact it from all logging.


```python
result = client.transliterate(
body=["konnichiwa"],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 407be44: all translation request body= values now use InputTextItem objects instead of raw strings.


```python
from azure.ai.ml import dsl, Input, Output
from azure.ai.ml.entities import Pipeline

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 407be44: removed the unused from azure.ai.ml.entities import Pipeline import; the example uses @dsl.pipeline only.

Comment on lines +128 to +133
# Orchestration projects expose the target intent result under the intent name
intent_result = next(
(i for i in prediction["intents"] if i["category"] == top_intent), {}
)
target_kind = intent_result.get("targetProjectKind") # e.g. "Luis" or "Conversation"
print(f"Routed to: {top_intent} ({target_kind})")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 407be44: orchestration intent access now treats prediction['intents'] as a dict keyed by intent name and uses prediction['intents'].get(top_intent, {}).

Copilot AI review requested due to automatic review settings July 15, 2026 19:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 136 out of 136 changed files in this pull request and generated 8 comments.

Comment thread tests/pnpm-workspace.yaml Outdated
Comment thread .github/plugins/azure-sdk-python/skills/m365-agents-py/references/capabilities.md Outdated
@LarryOsterman

Copy link
Copy Markdown
Member Author

@copilot Fix the CI pipeline error with the smoke test workflow.

- Delete tests/pnpm-workspace.yaml (caused CI 'packages field missing' error)
- Delete azure-cosmos-py/scripts/setup_cosmos_container.py (outside PR scope)
- Fix pydantic-models-py: clarify model_validate vs direct construction
- Fix m365-agents-py: remove activity.conversation.id (UnboundLocalError on empty stream)
- Fix azure-messaging-webpubsubservice-py: use close_user_connections, don't log bearer token URL
- Fix azure-messaging-webpubsubservice-py acceptance-criteria: update connection close example
- Fix azure-ai-transcription-py: correct LROPoller timeout pattern (done()+deadline loop)
- Fix azure-ai-transcription-py acceptance-criteria: remove DefaultAzureCredential anti-pattern
- Fix azure-ai-translation-text-py: use InputTextItem instead of raw strings in all bodies
- Fix azure-ai-ml-py: remove unused Pipeline import
- Fix azure-ai-language-conversations-py: fix orchestration intents (dict keyed by name)
Copilot AI review requested due to automatic review settings July 15, 2026 21:30
@LarryOsterman
LarryOsterman removed the request for review from Copilot July 15, 2026 21:30
Copilot AI review requested due to automatic review settings July 15, 2026 21:31
@LarryOsterman
LarryOsterman removed the request for review from Copilot July 15, 2026 21:31

Copilot AI commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@copilot Fix the remaining review comments.

Fixed all open threads in commit b9b9e6f:

  • azure-ai-translation-text-py: replaced raw strings with InputTextItem instances in all body= arguments (transliterate, lookup_dictionary_entries, find_sentence_boundaries, translate, and the async example)
  • azure-ai-ml-py: removed unused from azure.ai.ml.entities import Pipeline import
  • azure-ai-language-conversations-py: fixed orchestration intents — prediction['intents'] is a dict keyed by intent name, so now uses .get(top_intent, {}) instead of iterating with next()
  • pydantic-models-py capabilities: clarified that direct BaseModel(...) construction also runs validators; model_validate is for validating an existing dict/object
  • m365-agents-py capabilities: removed activity.conversation.id from ask_questionCopilotClient retains the conversation ID internally so the argument is not needed (and activity could be unbound on an empty opening stream)
  • azure-messaging-webpubsubservice-py non-hero: replaced close_all_connections(user_id=...) with close_user_connections(user_id=..., reason=...); stopped printing the bearer-token-bearing connection URL
  • azure-messaging-webpubsubservice-py acceptance-criteria: updated section 6 to use close_user_connections and correct the anti-pattern description
  • azure-ai-transcription-py non-hero: replaced the incorrect job.result(timeout=...) comment with an explicit done()/deadline poll loop
  • azure-ai-transcription-py acceptance-criteria: changed the DefaultAzureCredential anti-pattern to note it only fails on older SDK versions (current SDK supports TokenCredential)

@copilot Fix the CI pipeline error with the smoke test workflow.

The CI failure was caused by tests/pnpm-workspace.yaml (created in a prior session). It contained only allowBuilds: esbuild: true with no packages field — pnpm requires that field and immediately errors out with packages field missing or empty when running pnpm install in the tests directory.

Fixed in commit b9b9e6f by deleting tests/pnpm-workspace.yaml. The file didn't exist before this PR, so its removal restores the prior working state.

@LarryOsterman

Copy link
Copy Markdown
Member Author

@copilot Resolve review comments from the most recent run.

Copilot AI review requested due to automatic review settings July 15, 2026 21:37
@LarryOsterman
LarryOsterman removed the request for review from Copilot July 15, 2026 21:37

Copilot AI commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@copilot Resolve review comments from the most recent run.

Items 1–7 from the most recent review run were already resolved in prior commits. The remaining open thread was the acceptance criteria for azure-ai-transcription-py — fixed in the latest commit:

  • Added DefaultAzureCredential as a ✅ CORRECT pattern in section 1.1 (preferred for production)
  • Removed the anti-pattern that incorrectly classified DefaultAzureCredential as an error (section 1.3)
  • Updated the quick-reference table entry from "Use AzureKeyCredential, not DefaultAzureCredential" to "Use AzureKeyCredential or DefaultAzureCredential; never hardcode keys"

The evaluation harness will no longer penalize code that follows the skill's TokenCredential/DefaultAzureCredential recommendation.

Copilot AI commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@copilot Resolve review comments from the most recent run.

Done — I reviewed the active unresolved review threads and posted explicit per-thread Copilot resolution replies with commit references.

I added resolution comments to all 11 remaining unresolved reviewer threads:

  • 3590356931, 3590356971, 3590357000
  • 3590403943, 3590403987, 3590404018, 3590404048
  • 3590404074, 3590404104, 3590404116, 3590404146

Most fixes are in 407be44 (with bbe36fb for transcription timeout polish and 8b9dd9e for transcription acceptance-criteria alignment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants