deps: Update mu_msvm to v26.0.3 release#3421
deps: Update mu_msvm to v26.0.3 release#3421maheeraeron wants to merge 5 commits intomicrosoft:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the pinned microsoft/mu_msvm UEFI firmware dependency to the v26.0.3 release, aligning both the Nix-based firmware fetch and Flowey pipeline version selection.
Changes:
- Bump Nix
uefi_mu_msvmderivation to downloadmu_msvmv26.0.3 artifacts. - Update Flowey’s central
MU_MSVMversion constant to26.0.3.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| nix/uefi_mu_msvm.nix | Updates the mu_msvm release URL/version used by Nix to fetch MSVM.fd artifacts. |
| flowey/flowey_lib_hvlite/src/_jobs/cfg_versions.rs | Bumps the Flowey pipeline’s mu_msvm version constant to match the new release. |
| version = "26.0.3"; | ||
|
|
||
| src = fetchzip { | ||
| url = | ||
| "https://github.com/microsoft/mu_msvm/releases/download/v26.0.1/RELEASE-${archToolchain}-artifacts.tar.gz"; | ||
| "https://github.com/microsoft/mu_msvm/releases/download/v26.0.3/RELEASE-${archToolchain}-artifacts.tar.gz"; | ||
| stripRoot = false; | ||
| inherit hash; |
There was a problem hiding this comment.
Are the hashes coming from the sha256 entries here?:
https://github.com/microsoft/mu_msvm/releases/tag/v26.0.3
RELEASE-X64-VS2022 is: sha256:d8e320f89f0e4871e5dfac6433dde62c4ac96988a192fcd713f12a96ff6c07a5
RELEASE-AARCH64-CLANGPDB is: sha256:255fbd69f1cf1d3d769d8bad20e1533fe1fcde3436f53bd94d8d387fbbad70f6
The format looks different than what is on this file right now?
There was a problem hiding this comment.
Looks like it comes from some nix tool that you can get in linux, but there is some more conversion needed
There was a problem hiding this comment.
right you need to build nix locally otherwise this update will break it. if you're not ready to update this, you should hold off.
There was a problem hiding this comment.
ran sudo nix-shell --pure twice after emtpying those hash strings. The first one failed for x64 with:
unpacking source archive /build/RELEASE-X64-VS2022-artifacts.tar.gz
error: hash mismatch in fixed-output derivation '/nix/store/01c33fsp6vix5agcqkng26w6lcm22gkk-source.drv':
specified: sha256-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=
got: sha256-yThByWhaSWNPAdUyBrqzdY1VT/QIzf+yopFumoigajc=
And the second time fails for arm64 (after populating x64):
unpacking source archive /build/RELEASE-AARCH64-CLANGPDB-artifacts.tar.gz
error: hash mismatch in fixed-output derivation '/nix/store/lbj91hwmdv458pnp5602j8kl7wi4gj5y-source.drv':
specified: sha256-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=
got: sha256-L1xRlkfek0cajN55neRPnaBjFQnz/G3liZPLzIf2WD4=
These hashes match the state of what's in the PR today, so should be good to go
mu_msvm release notes: https://github.com/microsoft/mu_msvm/releases/tag/v26.0.3
This includes a fix to a critical race condition with EfiHvDxe where we freed a page back to DXE core without clearing the RO flags, then try to write to it again after.