Fix dir in Provider Context to prefer existing dir#35702
Open
anarmawala wants to merge 2 commits intomicrosoft:masterfrom
Open
Fix dir in Provider Context to prefer existing dir#35702anarmawala wants to merge 2 commits intomicrosoft:masterfrom
anarmawala wants to merge 2 commits intomicrosoft:masterfrom
Conversation
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Avatar Converged.badgeMask.normal.chromium.png | 5 | Changed |
vr-tests-react-components/Charts-DonutChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5581 | Changed |
vr-tests-react-components/Positioning 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 33 | Changed |
vr-tests-react-components/TagPicker 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 658 | Changed |
There were 1 duplicate changes discarded. Check the build logs for more information.
layershifter
requested changes
Jan 28, 2026
Member
layershifter
left a comment
layershifter
left a comment
There was a problem hiding this comment.
@anarmawala thx for contributing, however the current behavior is intentional as explicit is better over implicit.
For context, this also affects SSR scenarios as document is not available in Node env and the current PR will result in potentially different defaults on a client and a server.
Contributor
|
I’m with @layershifter on this - it could lead to a hydration issue. If you want to reuse |
Hotell
added
the
Resolution: Won't Do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please verify that:
masterbranchyarn changelocallyPrevious Behavior
The dir in ProviderContext automatically gets assumed to
ltr'.New Behavior
If we already had a direction specific on the html level then we should already take preference to that.
Related Issue(s)
The Provider Context now reads the
document.dirand if a value ofrtlorltrexists then use that, otherwise, assumeltr.