[Recommendations] Add parameters for noisy recommendations and rename query files#2011
Open
flanakin wants to merge 1 commit intofeatures/hubs-recsfrom
Open
[Recommendations] Add parameters for noisy recommendations and rename query files#2011flanakin wants to merge 1 commit intofeatures/hubs-recsfrom
flanakin wants to merge 1 commit intofeatures/hubs-recsfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the FinOps hubs recommendations feature by adding granular control over potentially noisy recommendation types, standardizing naming conventions, and improving the deployment experience through the Azure portal UI.
Changes:
- Added
enableAHBRecommendationsandenableSpotRecommendationsparameters to allow users to opt-in to potentially noisy recommendations about Azure Hybrid Benefit and Spot VMs - Renamed recommendation query files from
HubsRecommendations-*toRecommendations-Microsoft-*pattern and updated metadata to use PascalCase (ResourceGraph,Tenant) instead of lowercase - Added a new "Recommendations" tab to the Azure portal deployment UI (createUiDefinition.json) with clear descriptions of included and optional recommendations
- Changed
enableRecommendationsdefault tofalseto reflect preview status - Improved code organization by using conditional query file loading with the
union()pattern
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/templates/finops-hub/main.bicep | Added three new parameters for recommendations control (enableRecommendations, enableAHBRecommendations, enableSpotRecommendations) and passed them to hub module |
| src/templates/finops-hub/modules/hub.bicep | Added recommendation parameters, changed enableRecommendations default to false, removed analytics dependency requirement from recommendations condition, and passed new parameters to recommendations module |
| src/templates/finops-hub/modules/Microsoft.FinOpsHubs/Recommendations/app.bicep | Implemented conditional query loading using union pattern, removed unused storage account resource, renamed dataset to dataset_resourceGraph (consistent casing), added case-insensitive switch logic |
| src/templates/finops-hub/modules/Microsoft.FinOpsHubs/Recommendations/queries/*.json | Renamed all 10 query files to follow Recommendations-Microsoft-* pattern, updated metadata to use PascalCase (ResourceGraph, Tenant), changed source from "Azure Resource Graph" to "FinOps hubs" (except AdvisorCost), updated type field to match new naming |
| src/templates/finops-hub/createUiDefinition.json | Added new recommendations tab with clear UI explaining included vs optional recommendations, permissions requirements, and parameter mappings |
helderpinto
reviewed
Feb 18, 2026
...oft.FinOpsHubs/Recommendations/queries/Recommendations-Microsoft-BackendlessAppGateways.json
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Add
enableAHBRecommendationsandenableSpotRecommendationsparameters to control noisy recommendation types independently. Also renames query files to followRecommendations-Microsoft-*naming convention, adds a recommendations tab to createUiDefinition.json for the Azure portal deployment experience, and switchesenableRecommendationsto default off (preview).Fixes # N/A
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?