-
Notifications
You must be signed in to change notification settings - Fork 602
Upgarde: python-pytest-flake8 to version 1.3.0. #15295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgarde: python-pytest-flake8 to version 1.3.0. #15295
Conversation
9450541 to
3acb6b9
Compare
|
@AkarshHCL There are test failures for python-flake8. Can you check them? https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1007471&view=logs&j=bac295d9-f2e0-5165-e63e-e76f383e1a27&t=859205e3-cba0-55b5-b3f1-35d1c4f611a6 |
sandeepkarambelkar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use only version string for source tarball.
ed57813 to
3493f66
Compare
sandeepkarambelkar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM.
Buddy Build for stable maintainer review with latest changes - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1015495&view=results
Changes after last buddy build are related to changelog entries.
kgodara912
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As such changes looks fine and buddy build is successful. Please address below minor nits for consistency.
|
Buddy build is successful. |
kgodara912
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The buddy build is successful. Both the packages are compiling fine. Tests are also running fine. LGTM.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Upgrade python-pytest-flake8 to version 1.3.0.
Upstream reference link-https://github.com/coherent-oss/pytest-flake8
Change Log
Does this affect the toolchain?
NO
Test Methodology