Skip to content

Conversation

@AkarshHCL
Copy link
Contributor

@AkarshHCL AkarshHCL commented Dec 15, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Upgrade python-pytest-flake8 to version 1.3.0.
Upstream reference link-https://github.com/coherent-oss/pytest-flake8

Change Log
  • SPECS-EXTENDED/python-pytest-flake8/python-pytest-flake8.signatures.json
  • SPECS-EXTENDED/python-pytest-flake8/python-pytest-flake8.spec
  • cgmanifest.json
Does this affect the toolchain?

NO

Test Methodology
  • Scrrenshot of successful local build-
image

@AkarshHCL AkarshHCL requested review from a team as code owners December 15, 2025 14:58
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Dec 15, 2025
@AkarshHCL AkarshHCL force-pushed the topic_python-pytest-flake8 branch from 9450541 to 3acb6b9 Compare December 17, 2025 10:37
@AkarshHCL AkarshHCL changed the title Upgarde: python-pytest-flake8 to version 1.1.0. Upgarde: python-pytest-flake8 to version 1.3.0. Dec 17, 2025
@sandeepkarambelkar
Copy link
Contributor

@sandeepkarambelkar
Copy link
Contributor

@sandeepkarambelkar
Copy link
Contributor

Copy link
Contributor

@sandeepkarambelkar sandeepkarambelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use only version string for source tarball.

@AkarshHCL AkarshHCL force-pushed the topic_python-pytest-flake8 branch from ed57813 to 3493f66 Compare December 23, 2025 08:25
@sandeepkarambelkar
Copy link
Contributor

Copy link
Contributor

@sandeepkarambelkar sandeepkarambelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.
Buddy Build for stable maintainer review with latest changes - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1015495&view=results

Changes after last buddy build are related to changelog entries.

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As such changes looks fine and buddy build is successful. Please address below minor nits for consistency.

@AkarshHCL AkarshHCL requested a review from kgodara912 December 31, 2025 14:26
@kgodara912
Copy link
Contributor

Buddy build

@AkarshHCL
Copy link
Contributor Author

Buddy build is successful.

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buddy build is successful. Both the packages are compiling fine. Tests are also running fine. LGTM.

@sandeepkarambelkar sandeepkarambelkar merged commit 6c84dac into microsoft:3.0-dev Jan 2, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants