Mirror dotnet.exe's global.json search algorithm for test command #21573
+136
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinstapleton
requested review from
a team,
DergachevE and
tarunramsinghani
as code owners
Author
|
@microsoft-github-policy-service agree company="CoStar Group" |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in MTP mode
Context
Describe the context or motivation for this PR. Include links to any related Azure DevOps Work Items or GitHub issues.
📌 How to link to ADO Work Items
Issue #21523
Task Name
DotNetCoreCLIV2
Description
Update the
testcommand to leverage the same upward-traversal algorithm whichdotnet.exeuses to find theglobal.jsonfile (see here), starting at the working directory.Risk Assessment (Low / Medium / High)
Low.
Change Behind Feature Flag (Yes / No)
No. Current MTP/VSTest mode derivation is not feature-flagged.
Tech Design / Approach
Mirrored approach taken by other unit tests for this task.
Documentation Changes Required (Yes/No)
No
Unit Tests Added or Updated (Yes / No)
Yes. Unit tests were added to capture the new logic.
Additional Testing Performed
N/A
Logging Added/Updated (Yes/No)
Yes, debug log statements were added as appropriate.
Telemetry Added/Updated (Yes/No)
No
Rollback Scenario and Process (Yes/No)
No
Dependency Impact Assessed and Regression Tested (Yes/No)
No
Checklist