virtiofs: improve virtiofs performance by negotiating MAX_PAGES#40508
Draft
benhillis wants to merge 2 commits into
Draft
virtiofs: improve virtiofs performance by negotiating MAX_PAGES#40508benhillis wants to merge 2 commits into
benhillis wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates WSL’s NuGet dependency on Microsoft.WSL.DeviceHost to a newer version to pick up the virtiofs MAX_PAGES negotiation improvement (via updated wsldevicehost.dll), targeting better virtiofs sequential read/write performance.
Changes:
- Bump
Microsoft.WSL.DeviceHostpackage from1.2.23-0to1.2.24-0. - (Incidental)
packages.confignow includes a UTF-8 BOM on the XML declaration line.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
Author
|
Seeing some failures in CI I did not see locally, going to try to debug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates to a new wsldevicehost.dll that has this change: microsoft/openvmm#3447
The net result is a roughly 20-40% performance improvement for sequential read and write speeds, more details on the above openvmm pr.