Skip to content

[releases/28.x] [Shopify] When deleting a Shopify refund/return the Shopify refund/return line for all other refund/return are deleted#7428

Open
onbuyuka wants to merge 1 commit intoreleases/28.xfrom
bugs/629295-backport
Open

[releases/28.x] [Shopify] When deleting a Shopify refund/return the Shopify refund/return line for all other refund/return are deleted#7428
onbuyuka wants to merge 1 commit intoreleases/28.xfrom
bugs/629295-backport

Conversation

@onbuyuka
Copy link
Copy Markdown
Contributor

@onbuyuka onbuyuka commented Mar 27, 2026

Summary

Backport of bug #626081 to releases/28.x.

Fixes AB#629295

Original PR(s): #7320

## Summary
- **Bug 626081**: Deleting a single Shopify refund or return header
deletes lines for **all** refunds/returns, not just the deleted one
- **Root cause**: `SetRange("Field Name")` in `OnDelete` triggers was
called without a value parameter, which clears the filter instead of
setting it — causing `DeleteAll` to wipe the entire line table
- **Fix**: Pass `Rec."Refund Id"` / `Rec."Return Id"` as the second
parameter to `SetRange` in 3 locations across 2 files

Fixes
[AB#626081](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/626081)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@onbuyuka onbuyuka requested a review from a team as a code owner March 27, 2026 12:01
@github-actions github-actions bot added the AL: Apps (W1) Add-on apps for W1 label Mar 27, 2026
@onbuyuka onbuyuka enabled auto-merge (squash) March 27, 2026 12:03
@github-actions github-actions bot added this to the Version 28.1 milestone Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant