Skip to content

[Master]- Recurring billing is stuck due to an error related to updating the Subscription Line table#7404

Open
neeleshsinghal wants to merge 9 commits intomicrosoft:mainfrom
neeleshsinghal:bugs/Bug-623011-Recurring-billing-related-to-updating-the-Subscription-Line
Open

[Master]- Recurring billing is stuck due to an error related to updating the Subscription Line table#7404
neeleshsinghal wants to merge 9 commits intomicrosoft:mainfrom
neeleshsinghal:bugs/Bug-623011-Recurring-billing-related-to-updating-the-Subscription-Line

Conversation

@neeleshsinghal
Copy link
Copy Markdown
Contributor

@neeleshsinghal neeleshsinghal commented Mar 26, 2026 •
edited by github-actions bot
Loading

AB#629263

Work Item Bug 629263: [master] [ALL-E] Recurring billing is stuck due to an error related to updating the Subscription Line table

Fixes AB#629263

@github-actions github-actions bot added AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork Linked Issue is linked to a Azure Boards work item labels Mar 26, 2026
@github-actions github-actions bot modified the milestone: Version 29.0 Mar 26, 2026
@neeleshsinghal neeleshsinghal marked this pull request as ready for review March 26, 2026 08:47
@neeleshsinghal neeleshsinghal requested a review from a team as a code owner March 26, 2026 08:47
@JesperSchulz JesperSchulz added the Finance GitHub request for Finance area label Mar 27, 2026
JesperSchulz
JesperSchulz previously approved these changes Mar 27, 2026
View reviewed changes
@JesperSchulz JesperSchulz requested a review from Copilot March 27, 2026 08:53
Copilot AI reviewed Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes recurring billing getting stuck by preventing Subscription Line.CalculateNextToDate (with “Align to End of Month”) from returning a NextToDate earlier than FromDate, and adds a regression test for AB#623011.

Changes:

  • Add guard logic in Subscription Line date calculation to clamp NextToDate when it would fall before FromDate.
  • Add a new test verifying CalculateNextToDate does not return a date before FromDate for “Align to End of Month”.
  • Add a small helper to mock/insert a Subscription Line record for the test.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
.../RecurringBillingDocsTest.Codeunit.al Adds regression test + helper for reproducing and validating AB#623011 scenario
.../SubscriptionLine.Table.al Adjusts CalculateNextToDate logic to avoid returning a date before FromDate

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@neeleshsinghal neeleshsinghal requested a review from Copilot March 27, 2026 09:09
Copilot AI reviewed Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

@neeleshsinghal
Update src/Apps/W1/Subscription Billing/Test/Billing/RecurringBilling…
23e8094 
…DocsTest.Codeunit.al

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
neeleshsinghal and others added 2 commits March 27, 2026 15:13
@neeleshsinghal
Update src/Apps/W1/Subscription Billing/Test/Billing/RecurringBilling…
73de5ff 
…DocsTest.Codeunit.al

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@neeleshsinghal
Update src/Apps/W1/Subscription Billing/Test/Billing/RecurringBilling…
077a0e0 
…DocsTest.Codeunit.al

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@neeleshsinghal neeleshsinghal requested a review from Copilot March 27, 2026 09:30
Copilot AI reviewed Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@neeleshsinghal neeleshsinghal requested a review from Copilot March 27, 2026 09:40
Copilot AI reviewed Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@neeleshsinghal neeleshsinghal requested a review from Copilot March 27, 2026 09:58
Copilot AI reviewed Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

neeleshsinghal and others added 5 commits March 27, 2026 15:49
@neeleshsinghal
Update src/Apps/W1/Subscription Billing/Test/Billing/RecurringBilling…
8e4e140 
…DocsTest.Codeunit.al

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@neeleshsinghal
Update src/Apps/W1/Subscription Billing/Test/Billing/RecurringBilling…
5d5365d 
…DocsTest.Codeunit.al

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@neeleshsinghal
fixes
d673f1a
@neeleshsinghal
validate
856028b
@neeleshsinghal
also add vallidate
07ab7b0
@neeleshsinghal neeleshsinghal requested a review from Copilot March 28, 2026 04:29
Copilot AI reviewed Mar 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@neeleshsinghal neeleshsinghal requested a review from Copilot March 28, 2026 07:22
Copilot AI reviewed Mar 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@neeleshsinghal neeleshsinghal requested a review from Copilot March 28, 2026 10:57
Copilot AI reviewed Mar 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@neeleshsinghal neeleshsinghal requested a review from Copilot March 29, 2026 10:49
Copilot AI reviewed Mar 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@JesperSchulz JesperSchulz JesperSchulz left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

AL: Apps (W1) Add-on apps for W1 Finance GitHub request for Finance area From Fork Pull request is coming from a fork Linked Issue is linked to a Azure Boards work item

Projects

None yet

Milestone

Version 29.0

Development

Successfully merging this pull request may close these issues.

3 participants

@neeleshsinghal @JesperSchulz