Change action from 'None' to 'Error' for rules AA0073 and AA0237#7402
Draft
Change action from 'None' to 'Error' for rules AA0073 and AA0237#7402
Conversation
… variables - Updated test procedures in SecurityGroupsTest.Codeunit.al to replace instances of "SecurityGroupBuffer" with "TempSecurityGroupBuffer" for clarity and consistency. - Modified test procedures in SecurityGroupsUpgradeTest.Codeunit.al to utilize "TempSecurityGroupBuffer" instead of "SecurityGroupBuffer" for improved readability. - Refactored translation tests in TranslationTests.Codeunit.al to use "TempTranslationBuffer" in place of "TranslationBuffer" for better variable management. - Adjusted user settings tests in UserSettingsTests.Codeunit.al to implement "TempUserSettingsRec" instead of "UserSettingsRec" for enhanced code clarity.
…ed codeunits for clarity - Changed variable names from `FileShareAccount`, `Account`, `AFSDirectoryContent`, `SharePointFile`, etc. to `TempFileShareAccount`, `TempAccount`, `TempAFSDirectoryContent`, `TempSharePointFile`, etc. across various pages and codeunits in Azure File Service, SFTP, SharePoint, and Document Attachments modules. - Updated procedures to use temporary records for better readability and to avoid potential conflicts. - Ensured consistent naming conventions for temporary variables to enhance code maintainability.
…th Temp prefix - EDocE2ETest: EDocImportParameters->TempEDocImportParameters, EDocImportParams->TempEDocImportParams - EDocEmailTests: Account->TempAccount (Email Account global var) - EDocLinkToExistingTest: EDocImportParameters->TempEDocImportParameters - EDocProcessTest: EDocImportParameters->TempEDocImportParameters, EDocImportParams->TempEDocImportParams - EDocumentStructuredTests: EDocImportParameters->TempEDocImportParameters - NoSeriesCopilotAccuTests: NoSeriesGeneration->TempNoSeriesGeneration, NoSeriesGenerationDetail->TempNoSeriesGenerationDetail Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…SubscriptionBilling - ErrorMessageExtensibilityTests: ErrorHandlingParameters->TempErrorHandlingParameters - TrialBalanceExcelReports: EXRTrialBalanceBuffer->TempEXRTrialBalanceBuffer, TrialBalanceData->TempTrialBalanceData (7 procedures, 102 references) - ServiceCommitmentTest: OverdueServiceCommitments->TempOverdueServiceCommitments Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- ShpfyFilterMgtTest: TestFields->TempTestFields - ShpfyJsonHelperTest: TestFields->TempTestFields, TestFields2->TempTestFields2 (2 procedures) - ShpfySuggestPaymentTest: SuggestPayment->TempSuggestPayment (4 procedures) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…leanup Commit 7a2cc4e removed UnpublishExtension from the test cleanup, leaving CRM Sync Designer published (but uninstalled) after each test. On subsequent test runs, CommitGeneration() fails with AL0155 because the previously published extension already defines the same fields in MS_CRM_Mock ProxyExt. Fix: add UnpublishExtension() back using Published Application (the correct record for published-but-possibly-uninstalled extensions) and call it from Initialize() to ensure clean state before each test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…erTest cleanup" This reverts commit 8381270.
…n Initialize() UninstallExtension() only removes extensions from the installed apps list but leaves them published. When CommitGeneration() runs in a subsequent test (or pipeline re-run on a non-fresh environment), SaveCRMDesigner() creates a new package alongside the still-published old one, and AL0155 fires because both define the same fields in MS_CRM_Mock ProxyExt. Fix: in Initialize(), after uninstalling, also unpublish all CRM Sync Designer extensions using Published Application (the correct table for published but possibly-uninstalled extensions) before calling ClearGeneration(). This ensures a truly clean slate regardless of prior test run state. This is distinct from the previously removed UnpublishExtension() procedure: - Uses Published Application (not NAV App Installed App after uninstall) - Inline in Initialize() rather than a separate procedure - Placed before ClearGeneration() so the state is clean when it runs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…nsions in Initialize()" This reverts commit ffaed13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reinstate AA0073 and AA0237 after platform uptake
Fixes AB#626125