[Shopify] Pre-validate item before export in Add to Shopify action#7361
Merged
[Shopify] Pre-validate item before export in Add to Shopify action#7361
Conversation
Add CheckItemCanBeExported and CheckItemVariantCount to ShpfyProductExport so the Item Card action and the Add Item to Shopify report catch blocked items, empty descriptions, and too-many-variants before attempting export. This prevents the misleading confirmation-then-silent-skip flow. Consolidate duplicate checks: the report and CreateTempProduct now call the shared validation instead of maintaining their own copies. Fixes AB#626637 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
AL Documentation Audit
Documentation gaps were detected in the following apps:
- Shopify-Connector-Test: 0% documentation coverage
- Shopify-Connector: 93% documentation coverage
To generate documentation, run /al-docs init or /al-docs update using GitHub Copilot CLI or Claude Code.
This review is for awareness to help keep documentation in sync with code changes. It is okay to dismiss this request.
Groenbech96
requested changes
Mar 26, 2026
src/Apps/W1/Shopify/App/src/Products/Codeunits/ShpfyProductExport.Codeunit.al
Outdated
Show resolved
Hide resolved
onbuyuka
commented
Mar 26, 2026
src/Apps/W1/Shopify/App/src/Products/Codeunits/ShpfyProductExport.Codeunit.al
Outdated
Show resolved
Hide resolved
Co-authored-by: Onat Buyukakkus <55088871+onbuyuka@users.noreply.github.com>
|
darjoo
approved these changes
Mar 30, 2026
Groenbech96
approved these changes
Apr 1, 2026
src/Apps/W1/Shopify/App/src/Products/Page Extensions/ShpfyItemCard.PageExt.al
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckItemCanBeExportedandCheckItemVariantCounttoShpfyProductExportto validate items before export (blocked, empty description, >2048 variants)Add Item to Shopifyreport andCreateTempProductnow call the shared validation instead of maintaining their own copiesFixes AB#626637
🤖 Generated with Claude Code