Spline attachment surgery - #91
Open
gageLink wants to merge 6 commits into
Open
Conversation
adds Spline3D doc to tree
Adds new function documentation
Adding in new funcs, removing old variables and adding in new vector and support vars
exchange old logic with new vector logic, adding support functions where necessary.
adding SetAttachment function
This update is not as big as it seems, just adding in the attachment function, and binding it. GitHub decided to normalize the file, so thats why it looks so beeg
Author
|
Whoa my comment didnt actually talk about it sorry: The Lua function allows for adding attachments, as well as replacing attachments in the vector with other nodes The documentation is updated to reflect the added function. The UI is updated to account for this new method of storing attachments, in the property window for Spline3D nodes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started as a feature addition, giving a new Spline3D Lua function for adding attachment nodes, but Dingle suggested building out a new attachment system from scratch and uhhhh this is that.
I made a few design choices such as error handling, and starting conditions, and they were guided by the firm hand of "what would I want to see in a bibeo game endjinn"
tried my darndest to comment where i could but sometimes you get caught up in the heat of things and well...