Refactor: import shared types from @metacall/protocol to resolve TODOs (#30)#113
Open
madhavkapila wants to merge 2 commits intometacall:masterfrom
Open
Refactor: import shared types from @metacall/protocol to resolve TODOs (#30)#113madhavkapila wants to merge 2 commits intometacall:masterfrom
madhavkapila wants to merge 2 commits intometacall:masterfrom
Conversation
metacall#30) - Replaces duplicated local types in deploy, delete, and repository controllers with protocol imports. - Replaces custom file/runner scanning logic in install.ts with protocol's detectRunners and findFilesPath. - Bumps @metacall/protocol dependency to latest to support newly exported types.
…s and resolved linting and formatting errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following the recent merge of protocol #46, the FaaS controllers still contained legacy duplicated types and custom file-walking logic marked with
// TODO: Unify this with metacall/protocol.This PR removes that technical debt by synchronizing the FaaS HTTP request interfaces and dependency installation logic directly with the canonical
@metacall/protocolexports. It also bumps the protocol dependency to@0.1.27and adds"skipLibCheck": truetotsconfig.jsonto bypass compilation errors caused by the updatedaxiosDOM types included in the new protocol version.Related issue
Fixes #30
Type of change
How to test
Steps to verify the change locally:
npm installto pull the updated@metacall/protocoldependency.npm run lintandnpm run buildto verify the types compile cleanly and theskipLibCheckbypasses theaxiosconflict.npm run integrationto verify functionality.Checklist
Notes for reviewers
Important CI Note: The
npm run integrationtest will fail with Exit Code 5 (Error: Unexpected end of formin busboy).This is a pre-existing bug on
upstream/master. I investigated the failure locally and found it is caused byform-datamiscalculating theContent-Lengthof the Archiver stream sent by the CLI, which truncates the zip data over the network and aborts the stream.I kept this PR strictly focused on closing the technical debt for #30. I have written up a full root-cause analysis for the stream bug and will open a dedicated issue + PR in the
@metacall/protocolrepository shortly to fix the payload buffering and get the FaaS pipeline completely green again.Release notes
Refactored FaaS controllers and installation utilities to consume canonical types and file-walking methods directly from
@metacall/protocol.