Fix wrong XML format for supportedlock prop#12
Merged
Conversation
messense
approved these changes
Oct 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per specification from http://www.webdav.org/specs/rfc4918.html#PROPERTY_supportedlock :
PROPERTY_supportedlockshould have following format:While that returned by
webdav-handler-rsis:This made webdav libraries like https://github.com/lookfirst/sardine and https://github.com/thegrizzlylabs/sardine-android report error on parsing XML returned by
webdav-handler-rs(thus android apps using this library will fail to use webdav server ofwebdav-handler-rs). This PR fixes the format by specfication.This PR is also opened in miquels/webdav-handler-rs#24. I also opened several other PR there (miquels/webdav-handler-rs#11 and miquels/webdav-handler-rs#25), but are related to filesystem
quotafeature that is mainly relevant with webdav-server-rs binary.