-
Notifications
You must be signed in to change notification settings - Fork 342
Sx1262 Improvements - LoRa Radio reset #1287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
fschrempf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Here are some things I've noticed.
And maybe you could clean up the commits a little bit so there is one commit per logical change. You can just force-push if you cleaned up the history.
Thanks heaps for your time reviewing this! Great points all around and I'll respond/fix accordingly.
Good call - I seem to have a concrete skull when it comes to learning how Git works haha :) will fix that up too, cheers |
33856bc to
7401417
Compare
7401417 to
25bbb0b
Compare
|
@fschrempf would you mind taking another look for me now? All your comments should be resolved. |
fschrempf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Several fixes/improvements for SX1262 radios:
RADIOLIB_ERR_TX_TIMEOUT
RADIOLIB_ERR_SPI_CMD_FAILED
RADIOLIB_ERR_SPI_CMD_INVALID
RADIOLIB_ERR_SPI_WRITE_FAILED
RADIOLIB_ERR_SPI_READ_FAILED
RADIOLIB_ERR_CHIP_NOT_FOUND
RADIOLIB_ERR_DEVICE_BUSY
On SX1262-based variants without the P_LORA_RESET pin configured, this should NO-OP.