Skip to content

[WC-3262][WC-3323] provide better css variables mapping (part 1) #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gjulivan wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[WC-3262][WC-3323] provide better css variables mapping (part 1) #2128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0523ec1
fix: provide better css variables mapping
gjulivan Feb 19, 2026
7836b17
chore: three state checkbox css variables
gjulivan Mar 5, 2026
7ef7532
chore: update changelog
gjulivan Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/modules/data-widgets/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Changed

- We changed some stylings hardcoded values to have a better support for css variables

## [3.8.1] DataWidgets - 2026-02-19

### [3.8.1] DatagridDateFilter
Expand Down
33 changes: 17 additions & 16 deletions packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid-dropdown-filter.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
$scroll-shadow: /* Shadow Cover TOP */
linear-gradient(white 30%, rgba(255, 255, 255, 0)) center top,
/* Shadow Cover BOTTOM */ linear-gradient(rgba(255, 255, 255, 0), white 70%) center bottom,
/* Shadow TOP */ linear-gradient(0deg, rgba(255, 255, 255, 0.6), rgba(197, 197, 197, 0.6)) center top,
/* Shadow BOTTOM */ linear-gradient(180deg, rgba(255, 255, 255, 0.6), rgba(197, 197, 197, 0.6)) center bottom !default;

@mixin scroll-shadow {
background:
/* Shadow Cover TOP */
linear-gradient(white 30%, rgba(255, 255, 255, 0)) center top,
/* Shadow Cover BOTTOM */ linear-gradient(rgba(255, 255, 255, 0), white 70%) center bottom,
/* Shadow TOP */ linear-gradient(0deg, rgba(255, 255, 255, 0.6), rgba(197, 197, 197, 0.6)) center top,
/* Shadow BOTTOM */ linear-gradient(180deg, rgba(255, 255, 255, 0.6), rgba(197, 197, 197, 0.6)) center bottom;
background: var(--scroll-shadow, $scroll-shadow);

background-repeat: no-repeat;
background-size:
Expand All @@ -20,7 +21,7 @@
stroke-width: 0;
}
&:hover {
color: var(--brand-primary, #264ae5);
color: var(--brand-primary, $brand-primary);
path {
stroke-width: 1px;
}
Expand All @@ -37,13 +38,13 @@ $root: ".widget-dropdown-filter";
--wdf-popover-z-index: 50;
--wdf-popover-shadow: 0px 0px var(--wdf-outer-spacing) 0px var(--shadow-color-border, rgba(0, 0, 0, 0.2));
--wdf-bd-radius: var(--dropdown-border-radius, 7px);
--wdf-menu-bg-color: var(--label-info-color, #ffffff);
--wdf-menu-bg-color: var(--label-info-color, $label-info-color);
--wdf-menu-max-height: var(--dropdown-menu-max-height, 320px);
--wdf-menu-item-padding: 6px 10px;
--wdf-highlighted-bg-color: var(--color-default-light, #f5f6f6);
--wdf-selected-bg-color: var(--color-primary-lighter, #e6eaff);
--wdf-highlighted-bg-color: var(--color-default-light, $color-default-light);
--wdf-selected-bg-color: var(--color-primary-lighter, $color-primary-lighter);
--wdf-button-spacing: 8px;
--wdf-color: var(--gray-dark, black);
--wdf-color: var(--font-color-contrast, $color-contrast);
--wdf-state-icon-size: 16px;
--wdf-toggle-width: calc(4px + var(--wdf-state-icon-size) + var(--wdf-button-spacing));
--wdf-toggle-inline-end: var(--wdf-toggle-width);
Expand Down Expand Up @@ -243,7 +244,7 @@ $root: ".widget-dropdown-filter";
}

:where(#{$root}.variant-select[data-empty]) {
--wdf-input-placeholder-color: rgb(117, 117, 117);
--wdf-input-placeholder-color: var(--form-input-placeholder-color, $form-input-placeholder-color);
#{$root}-toggle {
color: var(--wdf-input-placeholder-color);
}
Expand All @@ -262,9 +263,9 @@ $root: ".widget-dropdown-filter";
:where(#{$root}.variant-tag-picker) {
#{$root}-selected-item {
align-items: center;
background-color: var(--color-primary-lighter, #e6eaff);
background-color: var(--color-primary-lighter, $color-primary-lighter);
border-radius: 26px;
color: #000;
color: var(--wdf-color);
display: inline-flex;
flex-flow: row nowrap;
font-size: var(--font-size-small, 12px);
Expand All @@ -274,7 +275,7 @@ $root: ".widget-dropdown-filter";
padding: var(--wdf-tag-padding);
margin: var(--spacing-smallest, 2px);
&:focus-visible {
outline: var(--brand-primary, #264ae5) auto 1px;
outline: var(--brand-primary, $brand-primary) auto 1px;
}
&:focus {
background-color: var(--color-primary-light, $color-primary-light);
Expand Down Expand Up @@ -322,7 +323,7 @@ $root: ".widget-dropdown-filter";
}

&:focus-visible {
outline: var(--brand-primary, #264ae5) solid 1px;
outline: var(--brand-primary, $brand-primary) solid 1px;
outline-offset: 2px;
}
}
Expand Down
10 changes: 5 additions & 5 deletions packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ $root: ".widget-datagrid";
top: 0;
height: 100%;
width: var(--spacing-smaller, $spacing-smaller);
background-color: $dragging-color-effect;
background-color: var(--dragging-color-effect, $dragging-color-effect);

z-index: 1;
}
Expand Down Expand Up @@ -371,7 +371,7 @@ $root: ".widget-datagrid";

&.widget-datagrid-selection-method-click {
.tr.tr-selected .td {
background-color: $grid-selected-row-background;
background-color: var(--grid-selected-row-background, $grid-selected-row-background);
}
}

Expand Down Expand Up @@ -400,7 +400,7 @@ $root: ".widget-datagrid";

&-loader-container {
align-items: center;
background-color: rgba(255, 255, 255, 1);
background-color: var(--bg-color-secondary, $bg-color-secondary);
display: flex;
height: 400px;
justify-content: center;
Expand Down Expand Up @@ -590,7 +590,7 @@ $root: ".widget-datagrid";

&:hover,
&:focus-visible {
background-color: var(--brand-primary-50, #e6e7f2);
background-color: var(--brand-primary-50, $bg-color-secondary);
}
}

Expand All @@ -603,7 +603,7 @@ $root: ".widget-datagrid";

:where(#{$root}-select-all-bar) {
grid-column: 1 / -1;
background-color: #f0f1f2;
background-color: var(--bg-color, $bg-color);
display: flex;
flex-flow: row nowrap;
align-items: center;
Expand Down
27 changes: 14 additions & 13 deletions packages/modules/data-widgets/src/themesource/datawidgets/web/_date-picker.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
/**
Classes for React Date-Picker font-unit and color adjustments
*/
$dg-day-color: #555;
$dg-day-range-color: #000;
$dg-day-range-background: #eaeaea;
$dg-outside-month-color: #c8c8c8;
$dg-text-color: #fff;
$dg-border-color: #d7d7d7;
$dg-day-color: #555 !default;
$dg-day-range-color: #000 !default;
$dg-day-range-background: #eaeaea !default;
$dg-outside-month-color: #c8c8c8 !default;
$dg-text-color: #fff !default;
$dg-border-color: #d7d7d7 !default;
$datepicker-border-color: #ccc !default;

.react-datepicker {
font-size: 1em;
border: 1px solid $border-color-default;
border: 1px solid var(--border-color-default, $border-color-default);
}

.react-datepicker-wrapper {
Expand Down Expand Up @@ -54,7 +55,7 @@ $dg-border-color: #d7d7d7;

.react-datepicker__day,
.react-datepicker__day--in-range {
color: $dg-day-color;
color: var(--dg-day-color, $dg-day-color);
border-radius: 50%;

&:hover {
Expand All @@ -70,7 +71,7 @@ $dg-border-color: #d7d7d7;
}

.react-datepicker__day--outside-month {
color: $dg-outside-month-color;
color: var(--dg-outside-month-color, $dg-outside-month-color);
}

.react-datepicker__day--today:not(.react-datepicker__day--in-range),
Expand Down Expand Up @@ -108,8 +109,8 @@ $dg-border-color: #d7d7d7;
.react-datepicker__year-text--in-range,
.react-datepicker__day--selecting-range-start
) {
background-color: $dg-day-range-background;
color: $dg-day-range-color;
background-color: var(--dg-day-range-background, $dg-day-range-background);
color: var(--dg-day-range-color, $dg-day-range-color);

&:hover {
background-color: var(--brand-primary, $brand-primary);
Expand All @@ -133,13 +134,13 @@ button.react-datepicker__close-icon::after {
}

.react-datepicker__navigation--previous {
border-right-color: #ccc;
border-right-color: var(--datepicker-border-color, $datepicker-border-color);
left: 8px;
border: none;
}

.react-datepicker__navigation--next {
border-left-color: #ccc;
border-left-color: var(--datepicker-border-color, $datepicker-border-color);
right: 8px;
border: none;
}
Expand Down
10 changes: 5 additions & 5 deletions packages/modules/data-widgets/src/themesource/datawidgets/web/_gallery.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@

Override styles of Gallery widget
========================================================================== */
$gallery-screen-lg: $screen-lg;
$gallery-screen-md: $screen-md;
$root: ".widget-gallery";
$gallery-screen-lg: $screen-lg !default;
$gallery-screen-md: $screen-md !default;
$root: ".widget-gallery" !default;

@mixin grid-items($number, $suffix) {
@for $i from 1 through $number {
Expand All @@ -28,7 +28,7 @@ $root: ".widget-gallery";

.widget-gallery-items {
display: grid;
grid-gap: var(--gallery-gap);
grid-gap: var(--gallery-gap, $gallery-gap);

/*
Desktop widths
Expand Down Expand Up @@ -67,7 +67,7 @@ $root: ".widget-gallery";

&:not(.widget-gallery-disable-selected-items-highlight) {
.widget-gallery-item.widget-gallery-clickable.widget-gallery-selected {
background: $brand-light;
background: var(--brand-primary-100, $brand-light);
}
}

Expand Down
16 changes: 8 additions & 8 deletions packages/modules/data-widgets/src/themesource/datawidgets/web/_three-state-checkbox.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ input[type="checkbox"].three-state-checkbox {
width: 100%;
height: 100%;
content: "";
border: 1px solid #e7e7e9;
border: 1px solid var(--form-input-border-color, $form-input-border-color);
border-radius: 4px;
background-color: transparent;
}
Expand All @@ -40,7 +40,7 @@ input[type="checkbox"].three-state-checkbox {
margin: 5px 4px;
transform: rotate(-45deg);
pointer-events: none;
border: 2px solid #ffffff;
border: 2px solid var(--btn-primary-color, $btn-primary-color);
border-top: 0;
border-right: 0;
}
Expand All @@ -59,13 +59,13 @@ input[type="checkbox"].three-state-checkbox {

&:not(:disabled):not(:checked):hover:after {
content: "";
border-color: #e7e7e9; // color of checkmark on hover
border-color: var(--form-input-border-color, $form-input-border-color); // color of checkmark on hover
}

&:indeterminate:before,
&:checked:before {
border-color: #264ae5;
background-color: #264ae5;
border-color: var(--brand-primary, $brand-primary);
background-color: var(--brand-primary, $brand-primary);
}

&:indeterminate:after,
Expand All @@ -74,17 +74,17 @@ input[type="checkbox"].three-state-checkbox {
}

&:disabled:before {
background-color: #f8f8f8;
background-color: var(--gray-50, #f8f8f8);
}

&:indeterminate:disabled:before,
&:checked:disabled:before {
border-color: transparent;
background-color: rgba(#264ae5, 0.4);
background-color: var(--brand-primary-200, $brand-light);
}

&:disabled:after {
border-color: #f8f8f8;
border-color: var(--gray-50, #f8f8f8);
}

& + .control-label {
Expand Down
25 changes: 17 additions & 8 deletions packages/modules/data-widgets/src/themesource/datawidgets/web/variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,30 @@
// Atlas UI compatible variable naming for data widgets
// Background colors
$bg-color: #fff !default;
$bg-color-secondary: #f5f8fd !default;
$grid-bg-striped: #fafafb !default;
$grid-bg-hover: #f5f6f6 !default;
$hover-color: #f8f8f8 !default;
$selected-color: #dadcde !default;

// Brand colors
$brand-primary: #264ae5 !default;
$brand-light: #e6eaff !default;
$grid-selected-row-background: $brand-light !default;
$color-contrast: #000 !default;
$color-base: #fff !default;

// Background
$bg-color: $color-base !default;
$bg-color-secondary: #f5f8fd !default;
$grid-bg-striped: #fafafb !default;
$grid-bg-hover: #f5f6f6 !default;
$hover-color: #f8f8f8 !default;
$selected-color: #dadcde !default;
$label-info-color: $color-base !default;
$color-default-light: $grid-bg-hover !default;
$color-primary-lighter: $brand-light !default;

// Text and icon colors
$gray-dark: #606671 !default;
$gray-darker: #3b4251 !default;
$pagination-caption-color: #0a1325 !default;
$caption-color: #0a1325 !default;
$form-input-placeholder-color: #757575 !default;
$form-input-border-color: $brand-primary !default;
$btn-primary-color: $color-base !default;

// Border colors
$border-color-default: #ced0d3 !default;
Expand Down
Loading