refactor(memory): drop dead DetectLanguage and qdrant GetByID#619
Merged
sheepbox8646 merged 6 commits intoJun 17, 2026
Conversation
PR memohai#569 moved the file-mode memory runtime from handlers into the builtin adapter package but kept the legacy any-typed wiring and per-runtime store interfaces. Drop the remaining type-erased plumbing: - builtin.Runtime: export the interface; NewBuiltinProvider takes Runtime directly instead of any + runtime cast. - NewBuiltinRuntimeFromConfig returns Runtime instead of (any, error). - NewFileRuntime returns Runtime, internal newFileRuntime takes the shared memoryStore interface; drop fileMemoryStore + sparseMemoryStore in favor of a single memoryStore in shared.go (with ArchiveAndRebuildFiles). - cmd/agent/app.go: drop the dead 'var fileRuntime any' branch. - builtin_test.go: drop the no-longer-reachable bad-service-type test.
The previous commit "drop dead DetectLanguage and qdrant GetByID" removed DetectLanguage from the LLM interface; recordingLLM only kept the method to satisfy the old interface. With it gone the stub is dead.
ChrAlpha
force-pushed
the
worktree-memory-tier2-cleanup
branch
from
fe8aa6e to
517de4f
Compare
sheepbox8646
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP after #569