Skip to content

January cleanup#203

Merged
melsman merged 2 commits intomasterfrom
january-cleanup
Jan 15, 2026
Merged

January cleanup#203
melsman merged 2 commits intomasterfrom
january-cleanup

Conversation

@melsman
Copy link
Owner

@melsman melsman commented Jan 14, 2026

Delete obsolete files:

  • Directory basis/web is from the SMLserver days and should be deleted.
  • Delete basis/basis-1997.mlb and friends.

Arrange that autobuild generates a config.h.in file in src/Runtime/ instead of in src/.

Avoid that Locks.h includes ../config.h, which creates problems when Regions.h is included from binary releases that do not include header-files in the parent directory of src/Runtime.

Copilot AI review requested due to automatic review settings January 14, 2026 22:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request performs a January cleanup by deleting obsolete files from the SMLserver days and reorganizing the build configuration to generate config.h in the correct directory.

Changes:

  • Removed obsolete #include "../config.h" from src/Runtime/Locks.h to fix include path issues in binary releases
  • Updated configure.ac to generate config.h.in in src/Runtime/ instead of src/
  • Deleted entire basis/web directory (SMLserver-era web framework files)
  • Removed obsolete basis library files (basis-1997.mlb and related 1997-standard ML files)
  • Removed commented-out code and cleaned up a duplicate line in compiler sources
  • Removed an obsolete file src/Common/Execution.sml

Reviewed changes

Copilot reviewed 54 out of 56 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Runtime/Locks.h Removed problematic include of ../config.h
configure.ac Changed config header location from src/config.h to src/Runtime/config.h
src/Compiler/native64.mlb Cleaned up comment placement and removed duplicate line
src/Compiler/Lambda/LambdaExp.sml Removed commented-out code
src/Common/Execution.sml Deleted obsolete file (entire file removed)
basis/web/* Deleted obsolete SMLserver web framework directory
basis/basis-1997.mlb and related Deleted obsolete 1997 ML standard basis files
basis/Makefile Removed cleanup references to deleted web directory

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@melsman melsman self-assigned this Jan 14, 2026
@melsman melsman added the cleanup Cleanup of source code label Jan 14, 2026
@melsman melsman merged commit e59b05e into master Jan 15, 2026
4 checks passed
mikkelwillen pushed a commit to mikkelwillen/mlkit that referenced this pull request Jan 21, 2026
* cleanup

* fix config.h issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Cleanup of source code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant