Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request performs a January cleanup by deleting obsolete files from the SMLserver days and reorganizing the build configuration to generate config.h in the correct directory.
Changes:
- Removed obsolete
#include "../config.h"fromsrc/Runtime/Locks.hto fix include path issues in binary releases - Updated
configure.acto generateconfig.h.ininsrc/Runtime/instead ofsrc/ - Deleted entire
basis/webdirectory (SMLserver-era web framework files) - Removed obsolete basis library files (
basis-1997.mlband related 1997-standard ML files) - Removed commented-out code and cleaned up a duplicate line in compiler sources
- Removed an obsolete file
src/Common/Execution.sml
Reviewed changes
Copilot reviewed 54 out of 56 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Runtime/Locks.h | Removed problematic include of ../config.h |
| configure.ac | Changed config header location from src/config.h to src/Runtime/config.h |
| src/Compiler/native64.mlb | Cleaned up comment placement and removed duplicate line |
| src/Compiler/Lambda/LambdaExp.sml | Removed commented-out code |
| src/Common/Execution.sml | Deleted obsolete file (entire file removed) |
| basis/web/* | Deleted obsolete SMLserver web framework directory |
| basis/basis-1997.mlb and related | Deleted obsolete 1997 ML standard basis files |
| basis/Makefile | Removed cleanup references to deleted web directory |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mikkelwillen
pushed a commit
to mikkelwillen/mlkit
that referenced
this pull request
Jan 21, 2026
* cleanup * fix config.h issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete obsolete files:
basis/webis from the SMLserver days and should be deleted.basis/basis-1997.mlband friends.Arrange that
autobuildgenerates aconfig.h.infile insrc/Runtime/instead of insrc/.Avoid that
Locks.hincludes../config.h, which creates problems when Regions.h is included from binary releases that do not include header-files in the parent directory ofsrc/Runtime.