Save lnkfile also when content is unchanged #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request fixes an issue where MLKit unnecessarily recompiled source files even when neither the file nor its dependencies had changed. The root cause was that lnk-files (which represent target code objects) were not being written when their content remained unchanged, causing the build system to lose track of whether recompilation had occurred.
Changes:
- Modified
pickleLnkFilefunction to always write lnk-files regardless of content changes, serving as a witness that compilation occurred - Added test case for pretty-printing record lists with different field orderings
- Updated NEWS.md with the fix description
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Manager/Manager.sml | Removed conditional check to always write lnk-files, ensuring file timestamps reflect compilation |
| test/repl/pretty.cmd | Added test case for pretty-printing a list of records with reordered fields |
| test/repl/pretty.out.ok | Added expected output for the new pretty-printing test case |
| NEWS.md | Added changelog entry documenting the recompilation fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mikkelwillen
pushed a commit
to mikkelwillen/mlkit
that referenced
this pull request
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes MLKit recompiles a source file
feven whenfhas not changed and none of its dependencies have changed. The reason is that by mistake the lnk-file (representing the target code objects forf) was not written if the content would not change.