Fix build: auto-create bin/, add README LFS note (24 samples)#4
Open
masonb-01 wants to merge 1 commit into
Open
Fix build: auto-create bin/, add README LFS note (24 samples)#4masonb-01 wants to merge 1 commit into
masonb-01 wants to merge 1 commit into
Conversation
masonb-01
commented
Jun 10, 2025
masonb-01
left a comment
masonb-01
left a comment
Author
There was a problem hiding this comment.
Changes
- Makefile
- Added a
bin:target (@mkdir -p bin) and made thedownbeatrule depend on it. - Declared
bin&runas.PHONY.
- Added a
Owner
|
Hi @masonb-01, thank you for the contribution! I'm very surprised and happy that you took a look at this project. Some implementation decisions probably look really odd, it's because this was a first semester bachelor's project and I had some criteria to meet to get points haha. How did you come across this project? I'm curious why the PR title and comments reference something about a readme update/broken audio yet the pr only contains the makefile update. Is that intentional? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.