Django yubin celery bypass backend and management commands by Coperh · Pull Request #69 · maykinmedia/django-common

Coperh · 2026-03-06T09:59:44Z

adds the ability to use django yubin without using celery tasks after version >2
Copies Message.enqueue, Message.retry_messages methods and django_yubin.queue_email_message and replaces the celery tasks
Copies django_yubin.backends.QueuedEmailBackend and replaces with modified queue_email_message
add maykin_common.yubin.engine.send_all to manually send yubin Messages

codecov · 2026-03-06T10:05:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.27%. Comparing base (c5f8985) to head (4771f6b).

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   99.18%   99.27%   +0.08%     
==========================================
  Files          27       34       +7     
  Lines         736      826      +90     
  Branches       87       92       +5     
==========================================
+ Hits          730      820      +90     
  Misses          4        4              
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

alextreme · 2026-03-10T16:58:23Z

@Coperh squash your commits and reference in your commit message the github issue in order to describe what you're doing

CharString

I'm not sure I understand the locking tests fully.

My underbelly would reach for a stateful property based test of the behaviour of the whole system. Generate actions and (failure) events, and have a simple model of what we expect (could be a few list[Message] as queues) and then if there is no sequential order for these actions that we did in parallel, than something is wrong with the system.

Or alternatively. Unittest the lock parts more tightly instead of trying to get the whole call_command chain testable. There are many moving parts there.

CharString · 2026-03-17T15:21:51Z

BTW, assert True + True == 2 and False + False == 0 so you can sum booleans.

CharString

Nice. Looking forward to replace my implementation with this. Just had an insight (I think) for some simplification.

Coperh · 2026-03-20T14:29:40Z

Removed YUBIN_LOCK_WAIT_TIMEOUT and tests/yubin/test_engine.py testing it

TBD: squash commits

alextreme · 2026-03-31T15:54:09Z

@sergei-maertens wil jij deze als hoeder van django-common mergen?

sergei-maertens · 2026-03-31T18:07:10Z

@sergei-maertens wil jij deze als hoeder van django-common mergen?

I see I have some pending review comments, I'll set aside some time this week hopefully. Please remind me if I forget.

sergei-maertens

My main concern here is that django-yubin will still pull in the celery dependency, and there is code here and there that detects availability of Celery based on the import succeeding or not. I'm afraid that there will still be situations where errors pop up because some thing is trying to dispatch a celery task while it's not configured. Is that addressed in any way?

sergei-maertens · 2026-03-09T21:34:29Z

    "django-stubs",
    "decouple-types",
    "redis",
+    "freezegun",


Can you try https://github.com/adamchainz/time-machine instead? There's a blog post describing why it's better and should replace freezegun usage.

sergei-maertens · 2026-03-09T21:35:07Z

 ]
+yubin = [
+    "django-yubin>=2.0.0",
+    "filelock",


do we need to take containerized applications into account that may not have a shared file system where the lock file is created?

sergei-maertens · 2026-03-09T21:36:05Z

+YUBIN_LOCK_PATH: Path = Path("/tmp") / "send_mail"
+YUBIN_LOCK_WAIT_TIMEOUT: int = 0


can you properly prefix the settings with MKN_ so that it's clear these are our own settings and not to be confused with the actual django-yubin?

sergei-maertens · 2026-03-09T21:36:38Z

+try:
+    import django_yubin
+except ImportError:
+    django_yubin = None


Please use the importlib way of detecting installed libraries instead, it's the recommended approach.

sergei-maertens · 2026-04-08T12:29:50Z

   health_checks
   otel
   apis
+   yubin


I'd argue that the settings documentation is going to be read more often than the Yubin workaround, so I'd move this down in the toc tree below settings.

sergei-maertens · 2026-04-08T13:24:07Z

+    """
+    Tests original Message.enqueue functionality
+    Should not mark the message as enqueued if not allowed
+    """


This confuses me. To me, the original is Message.enqueue, but that's not being called here, instead the separate function is being called. Is the intent to replace/monkeypatch the model method? If not, what happens if some code calls the model method instead of going through the custom function?

I really also want to see test docstrings in the form of:

Assert that X happens when Y...

this also applies to the test name itself. Now if you read the test name, it implies that enqueue can never actually queue the message, but clearly there are some conditions to take into account.

sergei-maertens · 2026-04-08T13:27:45Z

+    # yubin does not correctly use django settings
+    from django_yubin import settings
+
+    settings.MAILER_TEST_MODE = True
+    settings.MAILER_TEST_EMAIL = "test_mailer@example.com,test_mailer2@example.com"


does this correctly reset the settings after the test exits? This looks like a broken test isolation problem for future tests being added.

sergei-maertens

My main concern here is that django-yubin will still pull in the celery dependency, and there is code here and there that detects availability of Celery based on the import succeeding or not. I'm afraid that there will still be situations where errors pop up because some thing is trying to dispatch a celery task while it's not configured. Is that addressed in any way?

Co-authored-by: Chris Wesseling <chris.wesseling@protonmail.com>

Co-authored-by: Sergei Maertens <sergei-maertens@users.noreply.github.com>

Coperh · 2026-04-23T13:26:56Z

I think I addressed all of the comments

Coperh · 2026-04-23T15:13:59Z

An issue I found with the non-monkeypatched way is that yubin does run django_yubin.tasks.sent_email.delay(pk) in migration 0007 and that will not work if rabbitmq is not runnning

My bypass is to patch like here:

from django_yubin import tasks
tasks.send_email.delay = lambda *args, **kwargs: None

Coperh changed the title ~~✨ add django yubin celery bypass backend and management comm…~~ Django yubin celery bypass backend and management commands Mar 6, 2026

Coperh force-pushed the feature/yubin-celery-bypass branch from 579d925 to cc2712f Compare March 6, 2026 11:33

Coperh commented Mar 6, 2026

View reviewed changes

Comment thread maykin_common/yubin/management/commands/send_all_mail.py Outdated

Coperh commented Mar 6, 2026

View reviewed changes

Comment thread maykin_common/yubin/management/commands/send_all_mail.py Outdated

Coperh force-pushed the feature/yubin-celery-bypass branch 3 times, most recently from f11847d to 98a32f5 Compare March 10, 2026 13:49

Coperh marked this pull request as ready for review March 10, 2026 14:15

Coperh requested a review from CharString March 11, 2026 10:49

Coperh force-pushed the feature/yubin-celery-bypass branch from e3f055b to ba5c1f6 Compare March 11, 2026 15:16

CharString requested changes Mar 12, 2026

View reviewed changes

Coperh requested a review from CharString March 18, 2026 09:31

Coperh force-pushed the feature/yubin-celery-bypass branch 2 times, most recently from d237d51 to 02e2513 Compare March 18, 2026 09:33

CharString requested changes Mar 20, 2026

View reviewed changes

Comment thread maykin_common/yubin/backends.py Outdated

Comment thread maykin_common/yubin/utils.py

Comment thread maykin_common/yubin/engine.py Outdated

Coperh force-pushed the feature/yubin-celery-bypass branch from b2966e1 to af84718 Compare March 20, 2026 14:01

Coperh force-pushed the feature/yubin-celery-bypass branch from e44e536 to ba43f61 Compare March 20, 2026 15:17

Coperh requested a review from CharString March 20, 2026 15:23

CharString approved these changes Mar 31, 2026

View reviewed changes

alextreme requested a review from sergei-maertens March 31, 2026 15:54

sergei-maertens self-assigned this Mar 31, 2026

sergei-maertens requested changes Apr 8, 2026

View reviewed changes

✨ add django yubin celery bypass backend and management commands

d6d93af

Coperh and others added 5 commits April 23, 2026 11:05

♻️ add PR feedback

c318a63

Apply suggestions from code review

fe0ed31

Co-authored-by: Chris Wesseling <chris.wesseling@protonmail.com>

♻️ add more PR feedback

bab69ed

📝 add yubin celery bypass docs

5db0ae7

Apply suggestions from code review

4f81f8c

Co-authored-by: Sergei Maertens <sergei-maertens@users.noreply.github.com>

Coperh force-pushed the feature/yubin-celery-bypass branch from fdb5c4f to deff661 Compare April 23, 2026 09:05

changes based on code review

4771f6b

Coperh force-pushed the feature/yubin-celery-bypass branch from deff661 to 4771f6b Compare April 23, 2026 13:14

Coperh requested a review from sergei-maertens April 23, 2026 13:27

		YUBIN_LOCK_PATH: Path = Path("/tmp") / "send_mail"
		YUBIN_LOCK_WAIT_TIMEOUT: int = 0

Conversation

Coperh commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

alextreme commented Mar 10, 2026

Uh oh!

CharString left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CharString commented Mar 17, 2026

Uh oh!

CharString left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Coperh commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alextreme commented Mar 31, 2026

Uh oh!

sergei-maertens commented Mar 31, 2026

Uh oh!

sergei-maertens left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sergei-maertens left a comment

Choose a reason for hiding this comment

Uh oh!

Coperh commented Apr 23, 2026

Uh oh!

Coperh commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Coperh commented Mar 6, 2026 •

edited

Loading

codecov Bot commented Mar 6, 2026 •

edited

Loading

Coperh commented Mar 20, 2026 •

edited

Loading