Fix issue with previous PR. I should have made the PR into your issue branch rather than your main branch.#3
Merged
maupind merged 2 commits intoMar 13, 2024
Conversation
Also removes logging imports from files that don't do any logging and removes the example comment. Both of those changes are just minor non-functional changes to reduce the number of lines of non-functional code. The logging module is standard to python and there are plenty of examples in the official Python docs, so I don't think we gain much by including examples in each file.
Trying to differentiate between logging and printing. Logging is for informational and debug text. Printing is like a GUI. Printing is how you interact with the program on every run. That's how I'm thinking about it in my head right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that the changes you merged in here #1 weren't reflected in the PR you had opened here ManifoldRG#79
Made a few other small changes in the meantime. I'm realizing I shouldn't have made every print statement a
logger.whateverstatement. Prints are good as a way of interacting with the program the same way you would interact with a GUI (but in this case a TUI). Inputs/outputs/formatting/pretty-printing. Whereas logs are good for different verbosity levels of debugging. The Python logger lets you add useful context before every log, like a timestamp and a filepath. That extra context messes up the formatting that you intend for your TUI.