Skip to content

Conversation

@GiovanniCanali
Copy link
Collaborator

@GiovanniCanali GiovanniCanali commented Dec 4, 2025

Description

This PR deals with all collateral effects introduced by #699.

This PR fixes #748

Checklist

  • Code follows the project’s Code Style Guidelines
  • Tests have been added or updated
  • Documentation has been updated if necessary
  • Pull request is linked to an open issue

@GiovanniCanali GiovanniCanali self-assigned this Dec 4, 2025
@GiovanniCanali GiovanniCanali added enhancement New feature or request pr-to-fix Label for PR that needs modification labels Dec 4, 2025
@GiovanniCanali

This comment was marked as resolved.

@GiovanniCanali GiovanniCanali mentioned this pull request Dec 4, 2025
4 tasks
@GiovanniCanali GiovanniCanali force-pushed the update_zoo_domains branch 5 times, most recently from d3ea0b8 to fb44deb Compare December 11, 2025 14:01
@GiovanniCanali GiovanniCanali added pr-to-review Label for PR that are ready to been reviewed and removed pr-to-fix Label for PR that needs modification labels Dec 11, 2025
@GiovanniCanali GiovanniCanali marked this pull request as ready for review December 11, 2025 14:09
@GiovanniCanali GiovanniCanali requested a review from a team as a code owner December 11, 2025 14:09
@GiovanniCanali
Copy link
Collaborator Author

@dario-coscia @FilippoOlivo This PR also includes the final change we agreed upon in #699.

Copy link
Member

@FilippoOlivo FilippoOlivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GiovanniCanali, thanks for the PR. Can you please explain why you wrote something like:

...
        "D": spatial_domain.update(temporal_domain),
        "t0": spatial_domain.update(CartesianDomain({"t": 0})),
...

when you deal with unsteady problems?

@GiovanniCanali
Copy link
Collaborator Author

Hi @GiovanniCanali, thanks for the PR. Can you please explain why you wrote something like:

...
        "D": spatial_domain.update(temporal_domain),
        "t0": spatial_domain.update(CartesianDomain({"t": 0})),
...

when you deal with unsteady problems?

Hi @FilippoOlivo!

Here, the domains of the problem are defined. In particular, the domain D represents the full space–time domain, obtained as the Cartesian product of the spatial_domain [0,1] and the temporal_domain [0,1].

Similarly, the domain t0, corresponding to the initial condition, is defined as the entire spatial_domain [0,1] evaluated at the single time instant t=0.0.

Note that the update method returns a new domain instance; therefore, neither spatial_domain nor temporal_domain is modified in place. This method is used as a convenient shortcut to avoid redefining the domain from scratch.

Essentially,

        "D": spatial_domain.update(temporal_domain)

is the same as:

        "D": CartesianDomain("x": [0, 1], "t": [0,1])

@GiovanniCanali GiovanniCanali added pr-to-fix Label for PR that needs modification pr-to-review Label for PR that are ready to been reviewed and removed pr-to-review Label for PR that are ready to been reviewed pr-to-fix Label for PR that needs modification labels Dec 12, 2025
@GiovanniCanali GiovanniCanali merged commit 2888ae3 into mathLab:dev Dec 15, 2025
18 of 19 checks passed
@GiovanniCanali GiovanniCanali deleted the update_zoo_domains branch December 15, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request pr-to-review Label for PR that are ready to been reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants