-
Notifications
You must be signed in to change notification settings - Fork 92
Update problem/zoo and tests post domain refactory
#738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update problem/zoo and tests post domain refactory
#738
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
d3ea0b8 to
fb44deb
Compare
|
@dario-coscia @FilippoOlivo This PR also includes the final change we agreed upon in #699. |
fb44deb to
507c0b9
Compare
FilippoOlivo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GiovanniCanali, thanks for the PR. Can you please explain why you wrote something like:
...
"D": spatial_domain.update(temporal_domain),
"t0": spatial_domain.update(CartesianDomain({"t": 0})),
...when you deal with unsteady problems?
Hi @FilippoOlivo! Here, the domains of the problem are defined. In particular, the domain Similarly, the domain Note that the Essentially, "D": spatial_domain.update(temporal_domain)is the same as: "D": CartesianDomain("x": [0, 1], "t": [0,1]) |
b388e01 to
b544098
Compare
Description
This PR deals with all collateral effects introduced by #699.
This PR fixes #748
Checklist