Skip to content

Conversation

@kurtmckee
Copy link
Contributor

@kurtmckee kurtmckee commented Jan 23, 2026

The pre-commit configuration, and pylint configuration, prevent pre-commit hooks from successfully running.

Problem

I cloned the repo and ran pre-commit run -a. On Python 3.14, flynt threw this error:

flynt....................................................................Failed
- hook id: flynt
- exit code: 1

  Traceback (most recent call last):
    ...lib/python3.14/site-packages/flynt/transform/percent_transformer.py", line 217, in <module>
      ast.Str,
      ^^^^^^^
  AttributeError: module 'ast' has no attribute 'Str'

In addition, the pre-commit-hooks repo threw this warning:

[WARNING] repo `https://github.com/pre-commit/pre-commit-hooks` uses deprecated stage names (commit, push) which will be removed in a future version.

In addition, when the prospector hook ran, pylint threw this error:

************* Module .../pr-seekpath/.pylintrc
.pylintrc:1:0: R0022: Useless option value for '--disable',
'bad-continuation' was removed from pylint,
see https://github.com/pylint-dev/pylint/pull/3571. (useless-option-value)

Solution

I ran this command:

pre-commit autoupdate

and updated .pylintrc to remove the bad-continuation option.

Note

pylint found a number of issues, and this PR does not address those issues.

I recommend enabling pre-commit.ci for this repo so that all PRs are automatically linted.

@kurtmckee
Copy link
Contributor Author

Working on fixing the CI failure.

@kurtmckee kurtmckee force-pushed the allow-pre-commit-to-run branch from 39c39e0 to cfe6462 Compare January 29, 2026 12:29
@kurtmckee
Copy link
Contributor Author

Rebased and force-pushed

@t-reents
Copy link
Collaborator

Thanks!

@t-reents t-reents merged commit 30abec5 into materialscloud-org:main Jan 29, 2026
7 checks passed
@kurtmckee kurtmckee deleted the allow-pre-commit-to-run branch January 29, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants