Skip to content

layout_enclosures - #677

Open
YevgeniyaVoronina wants to merge 2 commits into
mate-academy:masterfrom
YevgeniyaVoronina:develop
Open

layout_enclosures#677
YevgeniyaVoronina wants to merge 2 commits into
mate-academy:masterfrom
YevgeniyaVoronina:develop

Conversation

@YevgeniyaVoronina

@YevgeniyaVoronina YevgeniyaVoronina commented Mar 23, 2021

Copy link
Copy Markdown

Comment thread src/index.html
Comment on lines +13 to +17
<section class="section">
<div class="text">
In programming languages, a closure is a technique for implementing lexically scoped name binding in a language with first-class functions. Operationally, a closure is a record storing a function together with an environment.
</div>
</section>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

watch yesterday's lecture till minute 8 and configure VScode auto-formatting for wrapping lines with more than 80 symbols
https://www.youtube.com/watch?v=ScTyxXA8SA8&list=PL7FuXFaDeEX0sQ0Zhwk2ixfwS1P6e0iuW&index=5

Comment thread src/style.css Outdated
background-color: #ddd;
padding: 10px;
border: 1px solid #e95d49;
margin: 0;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you've already add margin: 0 to all elements on the page

Suggested change
margin: 0;

Comment thread src/style.css
Comment on lines +6 to +10
* {
box-sizing: border-box;
padding: 0;
margin: 0;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this styles up (before body)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants