First commit for review - #676
Open
MykolaButylkov wants to merge 4 commits into
Open
Conversation
MykolaButylkov
commented
Mar 23, 2021
MykolaButylkov
commented
- DEMO LINK
- TEST REPORT LINK
VinnieJ-2k20
suggested changes
Mar 23, 2021
VinnieJ-2k20
left a comment
VinnieJ-2k20
left a comment
There was a problem hiding this comment.
Some changes needed.
Details in comments.
Comment on lines
+6
to
+14
| .first, | ||
| .third, | ||
| .second { | ||
| /* box-sizing: border-box; */ | ||
| background-color: #ddd; | ||
| border: 1px solid #e95d49; | ||
| padding: 10px; | ||
| margin: 0; | ||
| } |
There was a problem hiding this comment.
First - don't leave commented code.
Second - you don't need to create three separate classes here, it can be just one class.
Comment on lines
+19
to
+20
| padding: 10px; | ||
| border: 1px solid #e95d49; |
There was a problem hiding this comment.
You have same border and padding styles in three places.
Don't repeat yourself, create a common class for these styles.
VinnieJ-2k20
suggested changes
Mar 23, 2021
VinnieJ-2k20
left a comment
VinnieJ-2k20
left a comment
There was a problem hiding this comment.
Almost finished - just one more thing to fix.
Comment on lines
+6
to
+11
| .first, | ||
| .third, | ||
| .second { | ||
| background-color: #ddd; | ||
| margin: 0; | ||
| } |
There was a problem hiding this comment.
One more time:
Classes first, second and third belong to three different elements and have the same styles.
You can use just single class instead of these three.
MykolaButylkov
commented
Mar 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.