Skip to content

enclosures proj - #671

Open
RuslanaPodshyvalova wants to merge 3 commits into
mate-academy:masterfrom
RuslanaPodshyvalova:develop
Open

enclosures proj#671
RuslanaPodshyvalova wants to merge 3 commits into
mate-academy:masterfrom
RuslanaPodshyvalova:develop

Conversation

@RuslanaPodshyvalova

Copy link
Copy Markdown

DEMO LINK
TEST REPORT LINK

The project hasn't passed tests.
But project results are the same with pattern according to PerfectPixel.

Comment thread src/index.html Outdated
<body>
<div class="blue-box bordered">
<div class="yellow-box bordered">
<p id="qa-block" class="grey-box bordered">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add id="qa-block" to the outer block and test the result again, it should work after you do this

Comment thread src/style.css Outdated
}

.blue-box {
box-sizing: border-box;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add box-sizing: border-box rule to all elements on the page (use * selector for this)

Comment thread src/index.html Outdated
<div class="blue-box bordered">
<div class="yellow-box bordered">
<p class="grey-box bordered">
У програмуванні замиканням називають підпрограму, що виконується в середовищі, яке містить одну або більше зв’язаних змінних. Підпрограма має доступ до цих змінних під час виконання.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

watch today's lecture till minute 8 and set the right formatting to your VScode, such long text should be wrapped to the new line
https://www.youtube.com/watch?v=ScTyxXA8SA8&list=PL7FuXFaDeEX0sQ0Zhwk2ixfwS1P6e0iuW&index=5

…r all elements is set up; 3)the max size for code line is set up in vscode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants