Add a universal function to replace subgraph in OptimizationRule - #3353
Open
ericpai wants to merge 8 commits into
Open
Add a universal function to replace subgraph in OptimizationRule#3353ericpai wants to merge 8 commits into
ericpai wants to merge 8 commits into
Conversation
ericpai
force-pushed
the
refine/subgraph
branch
2 times, most recently
from
June 27, 2023 09:33
b9e6430 to
12525c0
Compare
wjsi
reviewed
Jun 27, 2023
ericpai
marked this pull request as ready for review
June 27, 2023 09:41
wjsi
reviewed
Jun 27, 2023
wjsi
previously approved these changes
Jun 28, 2023
wjsi
left a comment
wjsi
left a comment
Member
There was a problem hiding this comment.
LGTM. Seems errors are not relevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a univeral function
replace_subgraphtoOptimizationRulefor later use. The unit test cases are added as well.Fixes #3352
Check code requirements