Skip to content

Add task-lock-expiring-soon notification subscription #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CollinBeczak wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add task-lock-expiring-soon notification subscription #2852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/pages/Profile/Messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,12 @@ export default defineMessages({
"Receive a notification when your review status is updated by another reviewer.",
},

taskUnlockWarningNotificationsDescription: {
id: "Profile.form.taskUnlockWarningNotifications.description",
defaultMessage:
"Receive an email shortly before one of your locked tasks is about to be auto-unlocked. Useful when working in an external editor like JOSM.",
},

reviewCountNotificationsDescription: {
id: "Profile.form.reviewCountNotifications.description",
defaultMessage:
Expand Down
5 changes: 5 additions & 0 deletions src/pages/Profile/UserSettings/NotificationSettingsSchema.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ export const jsSchema = (intl) => {
team: notificationObject.team,
follow: notificationObject.follow,
metaReview: notificationObject.metaReview,
taskUnlockWarning: notificationObject.taskUnlockWarning,
reviewCount: notificationObject.reviewCount,
revisionCount: notificationObject.revisionCount,
},
Expand Down Expand Up @@ -185,6 +186,10 @@ export const uiSchema = (intl) => {
"ui:help": intl.formatMessage(messages.metaReviewNotificationsDescription),
"ui:FieldTemplate": CustomNotificationFieldTemplate,
},
taskUnlockWarning: {
"ui:help": intl.formatMessage(messages.taskUnlockWarningNotificationsDescription),
"ui:FieldTemplate": CustomNotificationFieldTemplate,
},
reviewCount: {
"ui:help": intl.formatMessage(messages.reviewCountNotificationsDescription),
"ui:FieldTemplate": CustomNotificationFieldTemplate,
Expand Down
4 changes: 4 additions & 0 deletions src/services/Notification/NotificationType/Messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ export default defineMessages({
id: "Notification.type.taskUnlockRequest",
defaultMessage: "Task Unlock Request",
},
taskUnlockWarning: {
id: "Notification.type.taskUnlockWarning",
defaultMessage: "Task Lock Expiring Soon",
},
});

export const subscriptionCountMessages = defineMessages({
Expand Down
3 changes: 3 additions & 0 deletions src/services/Notification/NotificationType/NotificationType.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export const NOTIFICATION_TYPE_REVIEW_COUNT = 12;
export const NOTIFICATION_TYPE_REVISION_COUNT = 13;
export const NOTIFICATION_TYPE_CHALLENGE_COMMENT = 14;
export const NOTIFICATION_TYPE_TASK_UNLOCK_REQUEST = 15;
export const NOTIFICATION_TYPE_TASK_UNLOCK_WARNING = 16;

export const NotificationType = Object.freeze({
system: NOTIFICATION_TYPE_SYSTEM,
Expand All @@ -36,6 +37,7 @@ export const NotificationType = Object.freeze({
metaReviewAgain: NOTIFICATION_TYPE_META_REVIEW_AGAIN,
challengeComment: NOTIFICATION_TYPE_CHALLENGE_COMMENT,
taskUnlockRequest: NOTIFICATION_TYPE_TASK_UNLOCK_REQUEST,
taskUnlockWarning: NOTIFICATION_TYPE_TASK_UNLOCK_WARNING,
});

export const NotificationSubscriptionType = Object.freeze({
Expand All @@ -48,6 +50,7 @@ export const NotificationSubscriptionType = Object.freeze({
team: NOTIFICATION_TYPE_TEAM,
follow: NOTIFICATION_TYPE_FOLLOW,
metaReview: NOTIFICATION_TYPE_META_REVIEW,
taskUnlockWarning: NOTIFICATION_TYPE_TASK_UNLOCK_WARNING,
});

export const NotificationCountType = Object.freeze({
Expand Down
Loading