Add task lock expiry reminder emails#1250
Draft
CollinBeczak wants to merge 1 commit into
Draft
Conversation
Emails users with an opt-in subscription shortly before one of their locked tasks is about to be auto-unlocked by the cleanLocks job. The reminder window is configurable (default 10 minutes) and the scheduled job is itself opt-in: omit `osm.scheduler.notifications.taskLockExpiryReminder.interval` to leave it unscheduled. - Adds NOTIFICATION_TYPE_TASK_UNLOCK_WARNING (16) and a `taskUnlockWarning` field on NotificationSubscriptions, defaulting to NOTIFICATION_EMAIL_NONE. - Adds the `sendTaskLockExpiryReminders` SchedulerActor job, which uses an atomic UPDATE...RETURNING on the `locked` table so overlapping runs cannot double-send. - Evolution 119 adds `reminder_sent_at` to `locked` and `task_unlock_warning` to `user_notification_subscriptions`.
|
ljdelight
reviewed
Jul 1, 2026
| -- the sendTaskLockExpiryReminders job does not email the same user about | ||
| -- the same lock more than once. | ||
| ALTER TABLE IF EXISTS locked | ||
| ADD COLUMN reminder_sent_at timestamp without time zone DEFAULT NULL;; |
Contributor
There was a problem hiding this comment.
Why would you remove the timezone? That will break things, the zone should always be tracked so that timings can be correct based on a user's zone (vs the server's configured timezone, which is not reliable).
edit: i know it's a draft, giving you a heads up on that one. also you'd wanna do a 'add column if not exists'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emails users with an opt-in subscription shortly before one of their locked tasks is about to be auto-unlocked by the cleanLocks job. The reminder window is configurable (default 10 minutes) and the scheduled job is itself opt-in: omit
osm.scheduler.notifications.taskLockExpiryReminder.intervalto leave it unscheduled.taskUnlockWarningfield on NotificationSubscriptions, defaulting to NOTIFICATION_EMAIL_NONE.sendTaskLockExpiryRemindersSchedulerActor job, which uses an atomic UPDATE...RETURNING on thelockedtable so overlapping runs cannot double-send.reminder_sent_attolockedandtask_unlock_warningtouser_notification_subscriptions.