fix: hybrid LEFT JOIN crash by avoiding re-join during fusion#4419
Open
sanikolaev wants to merge 2 commits intomasterfrom
Open
fix: hybrid LEFT JOIN crash by avoiding re-join during fusion#4419sanikolaev wants to merge 2 commits intomasterfrom
sanikolaev wants to merge 2 commits intomasterfrom
Conversation
Contributor
Linux release MCL test results1 179 tests 1 158 ✅ 17m 25s ⏱️ Results for commit f059947. ♻️ This comment has been updated with latest results. |
Treat all numeric values as numeric during tolerant comparison instead of only strings with an explicit decimal point, so platform-specific renderings like "0" vs "0.000000" compare equal. Also use a slightly wider epsilon for explicit knn_float_tolerance tests to absorb small cross-platform serialization drift in KNN distances and hybrid scores.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue #4418