renderer: add terminal-independent scene worker ABI - #125
Draft
lawrencecchen wants to merge 8 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency
cmux integration: manaflow-ai/cmux#8378
Verification
Draft while cmux completes leases, durable topology state, advanced Kitty/custom-shader parity, tagged restart tests, and process-scoped Metal profiling.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Summary by cubic
Adds a terminal‑independent semantic scene renderer ABI with a standalone Metal renderer targeting IOSurface, plus macOS‑only
GhosttySceneRendererKitfor out‑of‑process workers and an isolatedGhosttyConfigKitfor daemon config. Also instruments process‑lifetime counters for runtime app construction, PTY‑master opens/allocations, and surface constructors for external observability.New Features
GhosttyRenderSceneEncoderwith bounded full/delta codec and C APIs inghostty/vt/render_scene.h.ghostty_scene.h(ghostty_scene_init, frame leases/metadata, health events); shippedGhosttySceneRendererKit.xcframework.ghostty_config.h(ghostty_config_init, recursive load/finalize,ghostty_config_serialize); shippedGhosttyConfigKit.xcframework.ghostty_key_from_macos_keycode.Migration
emit-lib-vt-shared(native only),emit-scene-xcframework, andemit-config-xcframework.libghostty-internal.a.ghostty_scene_renderer_*fromghostty_scene.hfor worker rendering (and callghostty_scene_init).ghostty_render_scene_*fromghostty/vt/render_scene.hto capture/encode terminal scenes for workers.ghostty_config_*fromghostty_config.hfor daemon config resolution and serialization.ghostty_key_from_macos_keycode.Written for commit 0e750d5. Summary will update on new commits.