Skip to content

Simplify installation instructions#436

Open
fredden wants to merge 1 commit into
magento:developfrom
fredden:simplify-install-instructions
Open

Simplify installation instructions#436
fredden wants to merge 1 commit into
magento:developfrom
fredden:simplify-install-instructions

Conversation

@fredden

@fredden fredden commented Feb 1, 2023

Copy link
Copy Markdown
Member

The installation instructions for this coding standard are unnecessarily complex. Composer plugins are capable of performing the necessary registration automatically, without requiring the user to manually set up (or alter) any scripts sections in composer.json. The main Magento repository uses dealerdirect/phpcodesniffer-composer-installer to register the coding standard; let's use the same here.

See https://github.com/magento/magento2/blob/11846a1a10539470f2fe1522030ff42d62daa562/composer.json#L110 / magento/magento2#36791

Fixes #390

@Den4ik Den4ik left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fredden Thanks for your update.
Please review my comment

Comment thread composer.json Outdated
Den4ik
Den4ik previously approved these changes Feb 6, 2023

@Den4ik Den4ik left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks good for me

ihor-sviziev
ihor-sviziev previously approved these changes Apr 12, 2023
Den4ik
Den4ik previously approved these changes Apr 12, 2023
@fredden fredden dismissed stale reviews from Den4ik and ihor-sviziev via c534321 April 28, 2023 12:45
@sinhaparul

Copy link
Copy Markdown
Contributor

@magento import PR to magento-commerce/magento-coding-standard repository

@m2-github-services

Copy link
Copy Markdown
Contributor

@sinhaparul the Pull Request is successfully imported.

ihor-sviziev
ihor-sviziev previously approved these changes Jun 12, 2023
ihor-sviziev
ihor-sviziev previously approved these changes Aug 14, 2023
@fredden fredden force-pushed the simplify-install-instructions branch 2 times, most recently from 6d8a941 to afe826d Compare September 20, 2023 15:11
@fredden fredden force-pushed the simplify-install-instructions branch from afe826d to 2d3d36e Compare December 8, 2023 16:37
ihor-sviziev
ihor-sviziev previously approved these changes Dec 11, 2023
ihor-sviziev
ihor-sviziev previously approved these changes Oct 9, 2024
ihor-sviziev
ihor-sviziev previously approved these changes Jun 10, 2025
@fredden fredden force-pushed the simplify-install-instructions branch from 74d9bb9 to b181c3b Compare March 13, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHPStorm unable to run phpcs inspection

6 participants