Conversation
Signed-off-by: Tiago Natel de Moura <tiago.natel@neoway.com.br>
Signed-off-by: Tiago Natel de Moura <tiago.natel@neoway.com.br>
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 55.9% 55.91% +0.01%
==========================================
Files 22 22
Lines 3998 3999 +1
==========================================
+ Hits 2235 2236 +1
Misses 1519 1519
Partials 244 244
Continue to review full report at Codecov.
|
katcipis
left a comment
katcipis
left a comment
There was a problem hiding this comment.
I would love to start to see at least one full integration test for this kind of thing. The internal tests that are developed are quite hard to understand (at least to someone as limited as me ).
Besides that, LGTM
|
@katcipis by full integrated test you mean adding tests in the interpreter (internal/sh) also? |
|
@tiago4orion actually I was even thinking on testing through the public sh API (the same one we used on klb tests). Less likely to break and gives a code example of what is being done/fixed :-) |
|
@tiago4orion is this PR still relevant? Can we merge? |
|
missing some tests... |
|
tests are too cryptic.. I'll improve that soon |
Signed-off-by: Tiago Natel de Moura <tiago.natel@neoway.com.br>
| // $HOME+ # used in: $HOME+"/src" | ||
| // $HOME] # used in: $list[$index] | ||
| // $HOME) # used in: call($HOME) | ||
| if !isValidVariableSuffix(next) { |
There was a problem hiding this comment.
This is a nice refactoring. You sir are a gentleman:
|
@tiago4orion this will sound a little repetitive with what @vitorarins said, but can we merge this ? =P If it is important we can add better tests later =) (at least it does not break anything and the problem seems serious) |
4 participants
Closes #188