Skip to content

fix: Resolves issues with namespacing if the namespace has to be different than orka-default#83

Open
jasonjanderson wants to merge 1 commit into
macstadium:mainfrom
jasonjanderson:fix-namespacing
Open

fix: Resolves issues with namespacing if the namespace has to be different than orka-default#83
jasonjanderson wants to merge 1 commit into
macstadium:mainfrom
jasonjanderson:fix-namespacing

Conversation

@jasonjanderson

@jasonjanderson jasonjanderson commented Feb 24, 2026

Copy link
Copy Markdown

Summary

  • WaitForImage was hardcoded to use DefaultOrkaNamespace instead of the configured namespace, causing image saves to fail when the VM builder namespace differs from orka-default
  • Updated WaitForImage (interface, implementation, and mock) to accept a namespace parameter and pass it through to the underlying watcher
  • Fixed stepCreateImage cleanup and imageSaveNFS to use config.OrkaVMBuilderNamespace instead of the hardcoded DefaultOrkaNamespace

Changes

  • builder/orka/orka_client.go: Added namespace parameter to WaitForImage interface and implementation; pass namespace to waitForImage instead of DefaultOrkaNamespace
  • builder/orka/step_create_image.go: Use config.OrkaVMBuilderNamespace in both image cleanup and imageSaveNFS creation/wait calls
  • mocks/orka_client_mock.go: Updated mock to match the updated WaitForImage interface signature

@sonarqubecloud

Copy link
Copy Markdown

@jasonjanderson jasonjanderson marked this pull request as ready for review February 24, 2026 20:42
@celanthe celanthe requested a review from cjflan March 30, 2026 17:40
@celanthe celanthe requested a review from ispasov May 5, 2026 14:18
@ispasov

ispasov commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Hey,

Images are only available in the default namespace. This is the reason the namespace is hardcoded.

What is the error that you are getting when the namespace is different?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants