Skip to content

fix: harden setup step and clear shell history on image capture#33

Merged
celanthe merged 5 commits into
mainfrom
fix/clear-shell-history-on-setup
Jun 22, 2026
Merged

fix: harden setup step and clear shell history on image capture#33
celanthe merged 5 commits into
mainfrom
fix/clear-shell-history-on-setup

Conversation

@celanthe

@celanthe celanthe commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a clear_shell_history step to setup.sh that removes ~/.zsh_history and ~/.bash_history before image capture, preventing build session commands from appearing in published images
  • Adds timeout-minutes: 15 and SSH ServerAliveInterval/ServerAliveCountMax to the Run setup step so the job fails fast on a dropped connection instead of hanging indefinitely

Test plan

  • Run the workflow with images: sonoma to confirm setup completes and history files are absent in the saved image
  • Confirm the workflow fails cleanly (not hangs) if the SSH connection to the VM drops during setup

🤖 Generated with Claude Code

Removes ~/.zsh_history and ~/.bash_history before image capture so build
session commands are not visible in published images.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@celanthe celanthe self-assigned this Jun 4, 2026
@celanthe celanthe added the enhancement New feature or request label Jun 4, 2026
Temporary diagnostic to verify the runner is in the Aqua session
(asid=100003) after the SessionCreate plist fix.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@celanthe celanthe requested a review from spikeburton June 4, 2026 14:36
celanthe and others added 3 commits June 4, 2026 09:46
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove the temporary audit session logging and VM state polling steps
added during debugging. Add ServerAliveInterval/ServerAliveCountMax to
the Run setup SSH command and a 15-minute step timeout to prevent the
job from hanging silently if the SSH connection drops mid-install.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@celanthe celanthe changed the title fix: clear shell history at end of setup fix: harden setup step and clear shell history on image capture Jun 4, 2026
@celanthe celanthe merged commit 02fede6 into main Jun 22, 2026
8 of 10 checks passed
@celanthe celanthe deleted the fix/clear-shell-history-on-setup branch June 22, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants