fix: prevent premature loading of which-key.nvim - #198
Open
bbnolauv wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The recent fix #155 introduced
pcall(require, "which-key.state"). However, when using package managers likelazy.nvim, callingrequireon a lazy-loaded plugin's module will immediately force-load the plugin on the very first keystroke, bypassing any user-defined lazy-loading configurations (e.g.cmd,keys, oreventforwhich-key).Solution
Instead of directly calling
require, checkpackage.loaded["which-key.state"] ~= nilfirst.This prevents
lazy.nvim's globalrequirehook from intercepting the call and loading the plugin prematurely. Ifwhich-keyis already loaded, we then safely perform therequireas before.