Add a test with network pinning#9607
Merged
Merged
Conversation
Implicitly tests the ECH code paths, but not ECH servers on API 37.
This reverts commit e20b51c.
* Add local only EchTests taken from curl
Collaborator
Author
|
Wait for #9608 to land |
yschimke
marked this pull request as ready for review
July 26, 2026 14:45
swankjesse
approved these changes
Jul 26, 2026
| * consulted by the platform from API 37. Below that there's nothing to gain from the extra query, | ||
| * so [AndroidNetworkDns] does the plain address lookup. | ||
| */ | ||
| private fun dnsForNetwork(network: Network): Dns = |
Collaborator
There was a problem hiding this comment.
Off topic, but I think we structure AndroidNetworkDns very carefully, stuff like this might not be necessary
Collaborator
Author
There was a problem hiding this comment.
Yep, happy to get some guidance on how to structure it, and I'll hold us to correct on Android.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the proposed approach from #8376
And uses it test only to confirm we can use AndroidDns with a network on API 37.
These should probably move out of tests.