perf: merge RemarkAttacher double tree walk into single pass#294
Closed
ronaldtse wants to merge 2 commits into
Closed
perf: merge RemarkAttacher double tree walk into single pass#294ronaldtse wants to merge 2 commits into
ronaldtse wants to merge 2 commits into
Conversation
attach() now calls build_sorted_nodes_with_positions() once and passes the result to both attach_tagged_remarks() and attach_untagged_remarks(), eliminating the duplicate tree walk. Before: 2 × collect_nodes_with_positions() + 2 × sort (381K nodes each) After: 1 × collect_nodes_with_positions() + 1 × sort This was the largest memory overhead in remark attachment (~430MB for math_functions_schema). Estimated ~215MB saving per large parse.
The same array of child collection attribute names was hardcoded in two places: calculate_children_end_line and collect_children. Extracted to a CHILD_COLLECTION_ATTRIBUTES constant to eliminate duplication and make future maintenance easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collect_nodes_with_positionstree walk in RemarkAttacherattach()now builds the sorted nodes array once and reuses it for both tagged and untagged remark passesTest plan