feat(tools): scope operation journal identity by turn - #6
Draft
luoye520ww wants to merge 6 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replacement implementation for the rejected KunAgent#692 operation-journal direction.
Problem
The previous rejected design keyed operations by
threadId + callId. Compatibility model paths can produce fallback call ids such ascall_1across multiple turns in the same thread, causing unsafe result reuse.Changes implemented
kun/src/reliability/operation-journal.tswith a turn-scoped identity:threadIdturnIdcallIdtoolNameargsHashLocalToolHostafter approval/pre-hook/read/sandbox checks and before tool execution.call_1not colliding;.kun/review-plansfile from this PR scope.Important review blocker
The current
LocalToolHostdiff appears to include an unintended behavior regression arounduser_input/request_user_inputandcreate_plandefault tool construction. Before this can go upstream, restore the develop-branch structured GUI user-input behavior andcreateCreatePlanToolintegration while preserving the operation journal changes.Validation to run locally
I could not run local commands from this environment, so this remains draft until CI/local validation passes.