[Obsidian review blockers] - Step 4: Keep default effort visible - #2793
Merged
logancyang merged 1 commit intoAug 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to logancyang/obsidian-copilot-preview#285
Why
In Settings → Copilot → Basic → Agents → opencode, switching between models with and without effort levels removes and recreates the Default effort row. That makes the model list jump vertically while the user is toggling models.
What
The Default effort row now keeps its place whenever the default-model setting is visible. Models with effort levels keep the existing selectable options; models without them show a disabled Not supported select. Choosing the agent-native default shows the same stable row in its disabled Agent default state.
Non goal
This PR does not change model discovery, effort-capability detection, default-model persistence, session behavior, or CSS.
Screenshot
Unavailable — the full component-gallery build is blocked on the base branch by existing SVG-loader and Node-builtin bundling errors. The exact supported and unsupported states are included as focused gallery stories and covered by deterministic component tests.
Risk
Low
Review: skim Why and What, run Verification steps 2–4, confirm CI is green, and merge without reading the diff.
Verification