[Obsidian review blockers] - Step 2: Preserve provider request semantics - #2784
Closed
logancyang wants to merge 1 commit into
Closed
[Obsidian review blockers] - Step 2: Preserve provider request semantics#2784logancyang wants to merge 1 commit into
logancyang wants to merge 1 commit into
Conversation
logancyang
force-pushed
the
codex/issue-285-02-safe-network
branch
from
August 8, 2026 23:34
a915e36 to
a9ec766
Compare
logancyang
marked this pull request as ready for review
August 8, 2026 23:39
Owner
Author
Conservative risk dispositionRisk: High (highest in the original stack) — deferred and removed from the required stack. This PR touches provider HTTP and streaming semantics for Jina, Bedrock, and both GitHub Copilot adapters. Even a small transport change can affect authentication, streaming chunks, cancellation, custom endpoints, or response parsing, and the important paths require live-provider smoke tests. The Obsidian findings here are warning-only, and the legacy Copilot v3 provider work is lower priority. Recommendation: close this PR and revisit it independently only when provider-specific integration coverage is available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to logancyang/obsidian-copilot-preview#285
Why
Obsidian's review flags direct
fetchuse in Bedrock, Jina, and GitHub Copilot providers. Replacing every call withrequestUrlwould break streaming providers becauserequestUrlbuffers the response body, while leaving scattered global-fetch calls makes the exception hard to audit.What
Buffered provider requests use Obsidian's
requestUrlAPI. Providers that require a readable response stream obtain native fetch through one active-window adapter, preserving the existing streaming contract and receiver binding.fetchrequestUrlfetchreferenceNon goal
Screenshot
Not applicable — this step changes provider request transport and has no visual behavior.
Risk
High
Review: inspect
src/network/streamingFetch.ts—getNativeStreamingFetch— and the transport selection in the four changed provider modules line by line, then run Verification steps 1–4.Verification
npm test -- --runTestsByPath src/network/streamingFetch.test.ts --runInBand.npm test -- --runTestsByPath src/LLMProviders/BedrockChatModel.test.ts --runInBand.npm run build.Note
npm run formatpasses. The repo-widenpm run lintcommand still reports the review backlog tracked by issue #285; this commit's staged-file lint hook passes, and later stack steps remove that backlog.