[Codex effort format] - Step 2: Describe a collapsed row with its base blurb - #2767
Open
zeroliu wants to merge 1 commit into
Open
[Codex effort format] - Step 2: Describe a collapsed row with its base blurb#2767zeroliu wants to merge 1 commit into
zeroliu wants to merge 1 commit into
Conversation
zeroliu
marked this pull request as ready for review
August 8, 2026 04:24
codex advertises a `category:"model"` config option alongside its `models` catalog. The catalog carries one entry per (model × effort) pair and each blurb describes that one effort, so a collapsed row inherited whichever variant came first — GPT-5.6-Sol read "…Fast responses with lighter reasoning" on a row spanning low through ultra. Overlay the description from the model config option when the agent publishes one, since that channel lists base models and its blurb describes the whole row. Names need no overlay: `stripEffortSuffix` already resolves them from the variants. No-op for opencode (the option IS its catalog, so the group already carries it) and for the Claude SDK adapter, which synthesizes only a `thought_level` option. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
zeroliu
force-pushed
the
codex-effort-2-base-blurb
branch
from
August 8, 2026 04:38
bf9d198 to
36bd619
Compare
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to logancyang/obsidian-copilot-preview#271
Why
Once Codex's effort variants collapse into one picker row, that row still shows a blurb written for a single effort.
GPT-5.6-Solreads:"Fast responses with lighter reasoning" is codex-acp's description of
gpt-5.6-sol[low]. It is the first variant in the catalog, so it wins the grouping — on a row that now spanslowthroughultra. A reader pickingultrais told the model gives lighter reasoning.codex-acp already publishes the sentence that belongs there. Alongside its per-effort catalog it advertises a
category:"model"config option listing base models, where the same model reads simply "Latest frontier agentic coding model." Copilot ignores that channel because a backend reporting amodelscatalog never consults its config options for model metadata.What
A collapsed model row is described by its base model rather than by whichever effort variant happened to sort first.
Applies wherever a backend publishes both channels, which today is Codex alone. Nothing else changes: model names, effort dropdowns, grouping and selection are untouched, and the settings list and chat picker show the same rows as before.
Non goal
(low)suffix stripped; that already resolves correctly and gains nothing from a second source.session/set_model. Reading a description from the config option does not move the apply path onto it.modelscatalog.reasoning_effort,fast-modeandcollaboration_modeoptions codex-acp also advertises stay unread.Screenshot
Not captured — the blurb renders in Obsidian's chat model picker and Settings → Agent → Codex, and this environment cannot drive the Obsidian UI to load the branch build.
Replaying the live
codex-acp@1.1.10reply through the branch's realtranslateBackendStateproduces the descriptions those panes render:Verification step 2 reaches the real panes.
Risk
Low
translateBackendState.test.tscovers preferring the config-option blurb and falling back when the option omits a model, anddescriptor.test.tsasserts it against a transcribed live Codex replyReview: skim
WhyandWhat, run Verification step 2, and confirm CI is green.Verification
Requires
codex-acpinstalled and logged in.GPT-5.6-Solreads "Latest frontier agentic coding model." with no trailing clause about response speed or reasoning depth, and the same row still offerslowthroughultrain its effort dropdown.