fix(agent-mode): support current Codex ACP modes - #2673
Merged
Conversation
logancyang
force-pushed
the
codex/fix-2672-codex-acp-modes
branch
from
July 11, 2026 22:20
d5859c8 to
736bc01
Compare
logancyang
marked this pull request as ready for review
July 11, 2026 22:27
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 736bc01e6e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent/agent-full-accessIDs and the legacyauto/full-accessIDsCODEX_CONFIGfor current adapters while retaining legacy-cargumentsplanmode when one is advertisedagentmode while preserving user mode overrides@agentclientprotocol/codex-acpRoot cause
The Codex descriptor hard-coded the legacy Zed adapter's native mode IDs. Current
@agentclientprotocol/codex-acpreleases advertiseread-only,agent, andagent-full-access. The shared translator filters canonical modes against that inventory, soread-onlywas the only matching ID and Plan became the only visible picker option.The current adapter also ignores arbitrary argv in ACP server mode and reads Codex session config from
CODEX_CONFIG. Without the dual config transport, switching the recommended install package would drop Copilot's prompt wiring.User impact
Codex users can switch among Default, Plan, and Auto again instead of becoming trapped in Plan. Copilot's Obsidian framing, custom prompt, and pill syntax reach both current and legacy adapter families. Existing installations using the legacy adapter retain their prior behavior.
Validation
npm test -- --runInBand src/agentMode/backends/codex/CodexBackend.test.ts src/agentMode/backends/codex/codexModeMapping.test.ts src/agentMode/session/translateBackendState.test.ts— 66 tests passednpm run build— passedlogan-dev-vault— no uncaught errors or error-console entriesnpm run lintremains blocked in the existingeslint-plugin-obsidianmdpackage.json flat-config path before project source is analyzedFixes logancyang/obsidian-copilot-preview#212