feat(agent-mode): migrate Codex ACP and guide legacy users - #2670
Closed
zeroliu wants to merge 6 commits into
Closed
feat(agent-mode): migrate Codex ACP and guide legacy users#2670zeroliu wants to merge 6 commits into
zeroliu wants to merge 6 commits into
Conversation
zeroliu
force-pushed
the
otacon/impl-codex-acp-legacy-binary-guidance
branch
from
July 18, 2026 05:36
37de505 to
244fb02
Compare
…ex-acp-legacy-binary-guidance # Conflicts: # src/agentMode/backends/codex/CodexBackend.test.ts # src/agentMode/backends/codex/CodexBackend.ts # src/agentMode/backends/codex/descriptor.ts # src/settings/v2/components/AgentSettings.test.tsx # src/settings/v2/components/AgentSettings.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@agentclientprotocol/codex-acpsetupWhy: The superseded Zed Codex ACP adapter can fail at startup or hide current models, leaving users to blame Copilot without a clear diagnosis or recovery path.
What: Agent Mode now uses the maintained App Server adapter, classifies the configured installation before launch, blocks legacy/outdated binaries with exact migration guidance, and explains the adapter/bundled CLI/override relationship in settings and docs.
Decisions
@zed-industries/codex-acpas a blocking migration state, not a retryable generic boot error.CODEX_PATHfor advanced users, while identifying it as an unbundled override and surfacing its effective CLI version and warning.dist/index.jslaunching, without shell-based.cmdspawning.Changes
ef5716a8— Models Codex installation health and provenance with bounded shell-free probes, device-local caching, compatibility floors, Windows/POSIX resolution, and blocking remediation details. Verify legacy, supported bundled, override, invalid, and below-minimum classifications.edd984ea— Adopts the replacement adapter runtime contract throughCODEX_CONFIG,INITIAL_AGENT_MODE, current mode IDs, health-aware descriptor wiring, and Node-based Windows launch. Verify instructions, auth, model switching, modes, and cross-platform spawn descriptors remain correct.2e522a77— Surfaces migration and version clarity in chat and settings, prevents stale or blocked installs from starting, adds forced re-detection and accessible copy actions, and keeps healthy chat uncluttered. Verify blocked, invalid, unconfigured, bundled, override, and unrelated-backend UI states.37de5054— Replaces the legacy Windows installer/setup path and documents bundled versus overridden CLI provenance plus missing-model troubleshooting. Verify all setup commands target@agentclientprotocol/codex-acpand no user-facing path installs or launches the Zed adapter.Notes / follow-ups
models_cache.jsoncan independently affect the catalog.