-
Notifications
You must be signed in to change notification settings - Fork 1
chore: Automate extensions publishing #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4559fdf to
11d834b
Compare
11d834b to
15ff91d
Compare
15ff91d to
b302d81
Compare
e891086 to
ceb6192
Compare
ceb6192 to
dd8c93b
Compare
|
towards DRG-69 |
skyrpex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work!
I'd like to suggest merging publish-ovsx and publish-vs-marketplace into a single workflow so both are triggered with one action rather than running them separately, unless there's a specific reason not to do so.
In the future, we might want to automate publishing further, e.g. deducing the next version semantically.
939e857 to
195350e
Compare
Yes that's better. We now have one workflow that publishes to both marketplaces by default 1d2c4bb Agreed it can be automated further, some points are also mentioned in the ticket https://linear.app/localstack/issue/DRG-69/automate-publishing-to-vs-marketplace-and-open-vsx |
195350e to
2a295c0
Compare
2a295c0 to
f9c0042
Compare
f9c0042 to
1d2c4bb
Compare
skyrpex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great 👍🏻
Related to #70 This version is meant to supersede the pre-release versions (1.2.5) in the marketplaces. closes DRG-153
Motivation
This PR automates the publishing process for the LocalStack VS Code extension to both the Visual Studio Marketplace and Open VSX Registry. It introduces an automated workflow that can be triggered manually to publish the extension to both marketplaces, ensuring consistency and reducing manual effort.
The extension is published to both marketplaces by default, but that can be overwritten using the GH CLI with inputs, see example below.
Trigger:
gh workflow run publish.yml -f publish_vscode_marketplace=true -f publish_ovsx=false --ref branch-nameThe version is extracted from branch name (strips leading 'v' if present, since it is the convention so far for branch names) and validates it matches
package.jsonversion.Other changes
Added Makefile targets for
lintandtestto provide a single source of truth for quality checks.Testing
The workflows were tested by publishing version
1.2.5with the--pre-releaseflag. Contrary to what I initially described in DRG-69, VS Code Marketplace pre-releases cannot have version suffixes (like-beta.1). They use the same version format as regular releases. The test pre-releases (version 1.2.5) are now live in both marketplaces but won't auto-update users unless they opted-in. These cannot be unlisted.✔️ Successfully tested the pre-release extension in VSCode:

Next release should be version
1.2.6to supersede the pre-release versions. Will create the release1.2.6with a subsequent PR.