feat: show wallet name and make all columns sortable/filterable#131
Open
Mannohat wants to merge 1 commit intolnbits:mainfrom
Open
feat: show wallet name and make all columns sortable/filterable#131Mannohat wants to merge 1 commit intolnbits:mainfrom
Mannohat wants to merge 1 commit intolnbits:mainfrom
Conversation
- Add Wallet column showing resolved wallet name for each pay link - Make all table columns (Description, Amount, Currency) sortable - Add search filter input to filter across all columns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two improvements to the Pay Links table:
Wallet name column — Each pay link now shows the wallet name (resolved from the wallet ID) so users managing multiple wallets can easily see which link belongs to which wallet.
All columns sortable + search filter — Previously only "Created" was sortable. Now all column headers (Created, Wallet, Description, Amount, Currency, Username) are clickable for sorting. Also added a search input that filters across all visible columns.
Changes
static/index.js— Added "Wallet" column definition, addedsortable: trueto all columns, addedfield: 'min'to Amount for proper sort behavior, addedpayLinksFilterstate, added wallet name resolution inmapPayLink()static/index.vue— Added search input next to "Pay links" heading, connected:filterprop to the q-table