Implement SyclEvent#203
Merged
Merged
Conversation
Member
Author
|
@trws does this seem like a reasonable way to implement |
MrBurmark
force-pushed
the
feature/burmark1/sycl_event_impl
branch
2 times, most recently
from
a7ef020 to
dac34c4
Compare
MrBurmark
force-pushed
the
feature/burmark1/sycl_event_impl
branch
from
dac34c4 to
7875d1c
Compare
MrBurmark
requested review from
adayton1,
artv3,
johnbowen42,
kab163,
rchen20 and
rhornung67
MrBurmark
force-pushed
the
feature/burmark1/sycl_event_impl
branch
from
7875d1c to
df1d03f
Compare
adayton1
previously approved these changes
May 27, 2026
This uses an empty submit to get an event as there is no way to get an event from a queue without doing some kind of work, hopefully this gives a real useful event. Also add an explicit constructor from a sycl::event to allow the possibility of wrapping an event created outside of SyclEvent.
MrBurmark
force-pushed
the
feature/burmark1/sycl_event_impl
branch
from
df1d03f to
61b6325
Compare
adayton1
previously approved these changes
May 27, 2026
rhornung67
reviewed
May 27, 2026
rhornung67
previously approved these changes
May 27, 2026
MrBurmark
commented
May 27, 2026
Make a copy of event to work around needing a non-const event.
adayton1
previously approved these changes
May 27, 2026
MrBurmark
force-pushed
the
feature/burmark1/sycl_event_impl
branch
2 times, most recently
from
d96a36c to
ee9b1e8
Compare
Implemented via an empty submit that depends on the event.
MrBurmark
force-pushed
the
feature/burmark1/sycl_event_impl
branch
from
ee9b1e8 to
2bea9c0
Compare
adayton1
previously approved these changes
May 27, 2026
MrBurmark
force-pushed
the
feature/burmark1/sycl_event_impl
branch
from
af9b335 to
af72ed1
Compare
MrBurmark
force-pushed
the
feature/burmark1/sycl_event_impl
branch
from
af72ed1 to
525ce40
Compare
Member
Author
|
@homerdin Does this seem like a reasonable way to implement events on top of sycl? |
Contributor
|
@MrBurmark Yes, I think this is a good way to go. |
adayton1
reviewed
May 28, 2026
MrBurmark
commented
May 28, 2026
adayton1
approved these changes
May 28, 2026
rhornung67
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an implementation for
SyclEvent.This gets an event from the queue by calling submit but not actually submitting any work. Hopefully this gets an event without causing any significant overheads and is well defined behavior.
Note that this will not work for out of order queues. So now the
SyclEventconstructor throws an exception if you try to create an event from an out of order queue. We only make in order queues due to our semantic guarantees, but someone could make aSyclresource viaSyclFromQueuefrom an out of order queue.Depends on #182 .