fix(examples): wire online kv-events ZMQ subscriber#674
Open
Iceber wants to merge 1 commit into
Open
Conversation
|
Unsigned commits detected! Please sign your commits. For instructions on how to set up GPG/SSH signing and verify your commits, please see GitHub Documentation. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adds explicit setup/teardown for a static ZMQ subscriber alongside the existing KV events pool, making subscription management more explicit in the online KV events example.
Changes:
- Pass a shared
kvevents.ConfigintosetupEventsPoolrather than creating it inside the helper. - Introduce
setupEventsSubscriberto create/manage a static ZMQ subscriber viakvevents.SubscriberManager. - Ensure shutdown now includes subscriber manager shutdown before shutting down the events pool.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+253
to
+257
| subscriberManager := kvevents.NewSubscriberManager(pool) | ||
| if cfg.ZMQEndpoint != "" && !cfg.DiscoverPods { | ||
| if err := subscriberManager.EnsureSubscriber(ctx, staticSubscriberID, cfg.ZMQEndpoint, cfg.TopicFilter, false); err != nil { | ||
| return nil, fmt.Errorf("failed to create static ZMQ subscriber: %w", err) | ||
| } |
86fe4e7 to
b0364be
Compare
Signed-off-by: Iceber Gu <caiwei95@hotmail.com>
b0364be to
da60b37
Compare
Collaborator
|
Thanks for fixing this. The subscriber wiring matches the Helm kv-cache-manager path, and CI is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the online KV events example used by the Helm kv-cache-manager deployment
Previously, the online manager started the KV events pool but never created a ZMQ subscriber, so vLLM KV cache events published to
ZMQ_ENDPOINTwere not ingested. The manager could still serve HTTP scoring endpoints, but its KV block index would not be updated from runtime events.The fix wires
SubscriberManagerinto the online startup path:runZMQ_ENDPOINT/ZMQ_TOPIC